From ccfca780d5da69bd70d5d6d8a49c5e2fda14e20b Mon Sep 17 00:00:00 2001 From: BossZou <40255591+BossZou@users.noreply.github.com> Date: Mon, 27 Jul 2020 15:35:50 +0800 Subject: [PATCH] [skip ci] Rename dimension to dim in dev test case (#3030) Signed-off-by: yhz <413554850@qq.com> --- .../collection/test_create_collection.py | 4 ++-- tests/milvus_python_test/conftest.py | 10 +++++----- tests/milvus_python_test/utils.py | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/milvus_python_test/collection/test_create_collection.py b/tests/milvus_python_test/collection/test_create_collection.py index 9ccdc04e..7eb4d73e 100644 --- a/tests/milvus_python_test/collection/test_create_collection.py +++ b/tests/milvus_python_test/collection/test_create_collection.py @@ -243,7 +243,7 @@ class TestCreateCollectionInvalid(object): dimension = get_dim collection_name = gen_unique_str() fields = copy.deepcopy(default_fields) - fields["fields"][-1]["params"]["dimension"] = dimension + fields["fields"][-1]["params"]["dim"] = dimension with pytest.raises(Exception) as e: connect.create_collection(collection_name, fields) @@ -282,7 +282,7 @@ class TestCreateCollectionInvalid(object): ''' collection_name = gen_unique_str(collection_id) fields = copy.deepcopy(default_fields) - fields["fields"][-1]["params"].pop("dimension") + fields["fields"][-1]["params"].pop("dim") with pytest.raises(Exception) as e: connect.create_collection(collection_name, fields) diff --git a/tests/milvus_python_test/conftest.py b/tests/milvus_python_test/conftest.py index 3ef45e4d..c556b907 100644 --- a/tests/milvus_python_test/conftest.py +++ b/tests/milvus_python_test/conftest.py @@ -138,7 +138,7 @@ def jac_collection(request, connect): ori_collection_name = getattr(request.module, "collection_id", "test") collection_name = gen_unique_str(ori_collection_name) fields = gen_default_fields() - fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dimension": dimension, "metric_type": "JACCARD"}} + fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dim": dimension, "metric_type": "JACCARD"}} logging.getLogger().info(fields) try: connect.create_collection(collection_name, fields) @@ -158,7 +158,7 @@ def ham_collection(request, connect): ori_collection_name = getattr(request.module, "collection_id", "test") collection_name = gen_unique_str(ori_collection_name) fields = gen_default_fields() - fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dimension": dimension, "metric_type": "HAMMING"}} + fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dim": dimension, "metric_type": "HAMMING"}} try: connect.create_collection(collection_name, fields) except Exception as e: @@ -177,7 +177,7 @@ def tanimoto_collection(request, connect): ori_collection_name = getattr(request.module, "collection_id", "test") collection_name = gen_unique_str(ori_collection_name) fields = gen_default_fields() - fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dimension": dimension, "metric_type": "TANIMOTO"}} + fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dim": dimension, "metric_type": "TANIMOTO"}} try: connect.create_collection(collection_name, fields) except Exception as e: @@ -196,7 +196,7 @@ def substructure_collection(request, connect): ori_collection_name = getattr(request.module, "collection_id", "test") collection_name = gen_unique_str(ori_collection_name) fields = gen_default_fields() - fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dimension": dimension, "metric_type": "SUBSTRUCTURE"}} + fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dim": dimension, "metric_type": "SUBSTRUCTURE"}} try: connect.create_collection(collection_name, fields) except Exception as e: @@ -216,7 +216,7 @@ def superstructure_collection(request, connect): ori_collection_name = getattr(request.module, "collection_id", "test") collection_name = gen_unique_str(ori_collection_name) fields = gen_default_fields() - fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dimension": dimension, "metric_type": MetricType.SUPERSTRUCTURE}} + fields["fields"][-1] = {"field": "binary_vector", "type": DataType.BINARY_VECTOR, "params": {"dim": dimension, "metric_type": MetricType.SUPERSTRUCTURE}} try: connect.create_collection(collection_name, fields) except Exception as e: diff --git a/tests/milvus_python_test/utils.py b/tests/milvus_python_test/utils.py index d5e5d2af..cf262091 100644 --- a/tests/milvus_python_test/utils.py +++ b/tests/milvus_python_test/utils.py @@ -205,7 +205,7 @@ def gen_single_vector_fields(): continue if metric_type not in ["L2", "IP"] and data_type == DataType.FLOAT_VECTOR: continue - field = {"field": data_type.name, "type": data_type, "params": {"metric_type": metric_type, "dimension": dimension}} + field = {"field": data_type.name, "type": data_type, "params": {"metric_type": metric_type, "dim": dimension}} fields.append(field) return fields @@ -215,7 +215,7 @@ def gen_default_fields(): "fields": [ {"field": "int64", "type": DataType.INT64}, {"field": "float", "type": DataType.FLOAT}, - {"field": "vector", "type": DataType.FLOAT_VECTOR, "params": {"metric_type": "L2", "dimension": dimension}} + {"field": "vector", "type": DataType.FLOAT_VECTOR, "params": {"metric_type": "L2", "dim": dimension}} ], "segment_size": segment_size } -- GitLab