diff --git a/cpp/build.sh b/cpp/build.sh index 1279725162ff059f44ee708168ab359b4e0c137a..42a7d714a612d3b0f33456ee0fe87acbadc1654d 100755 --- a/cpp/build.sh +++ b/cpp/build.sh @@ -11,7 +11,7 @@ PROFILING="OFF" BUILD_FAISS_WITH_MKL="OFF" USE_JFROG_CACHE="OFF" KNOWHERE_OPTS="" -MILVUS_WITH_THRIFT="OFF" +MILVUS_WITH_THRIFT="ON" while getopts "p:d:t:uhlrcgmj" arg do diff --git a/cpp/src/CMakeLists.txt b/cpp/src/CMakeLists.txt index 8d2bd6b69e83ce43e5a35fafb71557a3727d5a74..63edcd3993f4ef0ae2514182d5876f28057b8532 100644 --- a/cpp/src/CMakeLists.txt +++ b/cpp/src/CMakeLists.txt @@ -198,33 +198,33 @@ set(knowhere_libs ) #if (MILVUS_WITH_THRIFT STREQUAL "ON") - add_executable(milvus_thrift_server - ${config_files} - ${server_files} - ${thriftserver_files} - ${utils_files} - ${thrift_service_files} - ${metrics_files} - ) +# add_executable(milvus_thrift_server +# ${config_files} +# ${server_files} +# ${thriftserver_files} +# ${utils_files} +# ${thrift_service_files} +# ${metrics_files} +# ) #else() - add_executable(milvus_grpc_server - ${config_files} - ${server_files} - ${grpcserver_files} - ${utils_files} - ${grpc_service_files} - ${metrics_files} - ) +# add_executable(milvus_grpc_server +# ${config_files} +# ${server_files} +# ${grpcserver_files} +# ${utils_files} +# ${grpc_service_files} +# ${metrics_files} +# ) #endif() - add_executable(milvus_server - ${config_files} - ${server_files} - ${thriftserver_files} - ${grpcserver_files} - ${utils_files} - ${thrift_service_files} - ${grpc_service_files} - ${metrics_files}) +add_executable(milvus_server + ${config_files} + ${server_files} + ${thriftserver_files} + ${grpcserver_files} + ${utils_files} + ${thrift_service_files} + ${grpc_service_files} + ${metrics_files}) if (ENABLE_LICENSE STREQUAL "ON") add_executable(get_sys_info ${get_sys_info_files}) @@ -234,25 +234,25 @@ if (ENABLE_LICENSE STREQUAL "ON") target_link_libraries(license_generator ${license_libs} ${third_party_libs}) # if(MILVUS_WITH_THRIFT STREQUAL "ON") - target_link_libraries(milvus_thrift_server ${server_libs} license_check ${knowhere_libs} ${third_party_libs}) +# target_link_libraries(milvus_thrift_server ${server_libs} license_check ${knowhere_libs} ${third_party_libs}) # else() - target_link_libraries(milvus_grpc_server ${server_libs} license_check ${knowhere_libs} ${third_party_libs}) +# target_link_libraries(milvus_grpc_server ${server_libs} license_check ${knowhere_libs} ${third_party_libs}) # endif() target_link_libraries(milvus_server ${server_libs} license_check ${knowhere_libs} ${third_party_libs}) else () # if(MILVUS_WITH_THRIFT STREQUAL "ON") - target_link_libraries(milvus_thrift_server ${server_libs} ${knowhere_libs} ${third_party_libs}) +# target_link_libraries(milvus_thrift_server ${server_libs} ${knowhere_libs} ${third_party_libs}) # else() - target_link_libraries(milvus_grpc_server ${server_libs} ${knowhere_libs} ${third_party_libs}) +# target_link_libraries(milvus_grpc_server ${server_libs} ${knowhere_libs} ${third_party_libs}) # endif() target_link_libraries(milvus_server ${server_libs} ${knowhere_libs} ${third_party_libs}) endif() #if (MILVUS_WITH_THRIFT STREQUAL "ON") - install(TARGETS milvus_thrift_server DESTINATION bin) +# install(TARGETS milvus_thrift_server DESTINATION bin) #else() - install(TARGETS milvus_grpc_server DESTINATION bin) +# install(TARGETS milvus_grpc_server DESTINATION bin) #endif() install(TARGETS milvus_server DESTINATION bin) diff --git a/cpp/src/server/Server.cpp b/cpp/src/server/Server.cpp index ea2a5b735214c0d017904dfc858f6e7bddc73d09..b46382e38da9250a26aa0f3228c04dbf59b8dac6 100644 --- a/cpp/src/server/Server.cpp +++ b/cpp/src/server/Server.cpp @@ -229,9 +229,6 @@ Server::StartService() { std::thread grpc_thread = std::thread(&grpc::GrpcMilvusServer::StartService); thrift_thread.join(); grpc_thread.join(); -// -// MilvusServer::StartService(); -// grpc::GrpcMilvusServer::StartService(); } void diff --git a/cpp/src/server/thrift_impl/MilvusServer.cpp b/cpp/src/server/thrift_impl/MilvusServer.cpp index eb501d57eb72bd0d05dc6ec913c14502954bc9cf..8cea76828337e38f8d112d1bdeda9d4d385a7c95 100644 --- a/cpp/src/server/thrift_impl/MilvusServer.cpp +++ b/cpp/src/server/thrift_impl/MilvusServer.cpp @@ -96,14 +96,9 @@ MilvusServer::StartService() { void MilvusServer::StopService() { - auto stop_server_worker = [&]{ - if(s_server != nullptr) { - s_server->stop(); - } - }; - - std::shared_ptr stop_thread = std::make_shared(stop_server_worker); - stop_thread->join(); + if(s_server != nullptr) { + s_server->stop(); + } } }