From af5f30448f4e7e9fffa14b634634c635c4af8aa6 Mon Sep 17 00:00:00 2001 From: Cai Yudong Date: Fri, 21 Aug 2020 16:26:39 +0800 Subject: [PATCH] [skip ci] update clang-tidy rules (#3386) * [skip ci] update clang-tidy rules Signed-off-by: yudong.cai * [skip ci] update clang-tidy rules Signed-off-by: yudong.cai --- .clang-tidy | 4 ++-- core/CMakeLists.txt | 1 - core/build-support/lint_exclusions.txt | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 0a47511c..88e28ad1 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -23,8 +23,8 @@ Checks: > modernize-*, -modernize-pass-by-value # produce HeaderFilterRegex from core/build-support/lint_exclusions.txt with: -# echo -n '^('; sed -e 's/*/\.*/g' core/build-support/lint_exclusions.txt | tr '\n' '|'; echo ')$' -HeaderFilterRegex: '^(.*cmake-build-debug.*|.*cmake-build-release.*|.*cmake_build.*|.*thirdparty.*|.*src/grpc.*|.*milvus/include.*|.*unittest.*)$' +# echo -n '^?!('; sed -e 's/*/\.*/g' core/build-support/lint_exclusions.txt | tr '\n' '|'; echo ')$' +HeaderFilterRegex: '^?!(.*cmake-build-debug.*|.*cmake-build-release.*|.*cmake_build.*|.*thirdparty.*|.*src/grpc.*|.*milvus/include.*|.*unittest.*)$' AnalyzeTemporaryDtors: true CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines diff --git a/core/CMakeLists.txt b/core/CMakeLists.txt index 17595744..e3d8a47d 100644 --- a/core/CMakeLists.txt +++ b/core/CMakeLists.txt @@ -118,7 +118,6 @@ if("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1" OR CLANG_TIDY_FOUND) # with various development tools, such as Vim's YouCompleteMe plugin. # See http://clang.llvm.org/docs/JSONCompilationDatabase.html set(CMAKE_EXPORT_COMPILE_COMMANDS ON) - set(CMAKE_CXX_STANDARD_INCLUDE_DIRECTORIES ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES}) endif() # diff --git a/core/build-support/lint_exclusions.txt b/core/build-support/lint_exclusions.txt index fe64fe83..78e74551 100644 --- a/core/build-support/lint_exclusions.txt +++ b/core/build-support/lint_exclusions.txt @@ -4,4 +4,4 @@ *thirdparty* *src/grpc* *milvus/include* -*unittest* \ No newline at end of file +*unittest* -- GitLab