From 8e7d902a847d08d9a7ac44f712968cab2dfeb636 Mon Sep 17 00:00:00 2001 From: Yu Kun Date: Fri, 23 Aug 2019 13:10:46 +0800 Subject: [PATCH] use memcpy in insert Former-commit-id: fd1de2eca25ffc38481a49c8da914d4cb6ae7449 --- cpp/src/server/grpc_impl/GrpcRequestTask.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cpp/src/server/grpc_impl/GrpcRequestTask.cpp b/cpp/src/server/grpc_impl/GrpcRequestTask.cpp index 8a6ce0c2..49dfd073 100644 --- a/cpp/src/server/grpc_impl/GrpcRequestTask.cpp +++ b/cpp/src/server/grpc_impl/GrpcRequestTask.cpp @@ -459,10 +459,8 @@ InsertTask::OnExecute() { std::to_string(table_info.dimension_); return SetError(error_code, error_msg); } - //TODO: use memcpy - for (size_t j = 0; j < table_info.dimension_; j++) { - vec_f[i * table_info.dimension_ + j] = insert_param_.row_record_array(i).vector_data(j); - } + memcpy(static_cast(&vec_f[i * table_info.dimension_]), static_cast(insert_param_.row_record_array(i).vector_data().data()), + table_info.dimension_ * sizeof(float)); } rc.ElapseFromBegin("prepare vectors data"); -- GitLab