From 55cb64bbfb7d4a32fd1289137631f0f0de4cd2d1 Mon Sep 17 00:00:00 2001 From: antirez Date: Thu, 6 Aug 2015 15:08:54 +0200 Subject: [PATCH] flushSlavesOutputBuffers(): details clarified via comments. Talking with @oranagra we had to reason a little bit to understand if this function could ever flush the output buffers of the wrong slaves, having online state but actually not being ready to receive writes before the first ACK is received from them (this happens with diskless replication). Next time we'll just read this comment. --- src/networking.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/networking.c b/src/networking.c index 782dc6c4a..336561e10 100644 --- a/src/networking.c +++ b/src/networking.c @@ -1668,6 +1668,12 @@ void flushSlavesOutputBuffers(void) { client *slave = listNodeValue(ln); int events; + /* Note that the following will not flush output buffers of slaves + * in STATE_ONLINE but having put_online_on_ack set to true: in this + * case the writable event is never installed, since the purpose + * of put_online_on_ack is to postpone the moment it is installed. + * This is what we want since slaves in this state should not receive + * writes before the first ACK. */ events = aeGetFileEvents(server.el,slave->fd); if (events & AE_WRITABLE && slave->replstate == SLAVE_STATE_ONLINE && -- GitLab