diff --git a/lib/web_ui/dev/chrome.dart b/lib/web_ui/dev/chrome.dart index 9ae072b85d168b049cc21ac1c0b6dc2c2a31c4db..728df7b134dfff9dda4d9cdf3d18d243a6d0a4e5 100644 --- a/lib/web_ui/dev/chrome.dart +++ b/lib/web_ui/dev/chrome.dart @@ -9,7 +9,7 @@ import 'dart:io'; import 'package:pedantic/pedantic.dart'; -import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports +import 'package:test_core/src/util/io.dart'; import 'browser.dart'; import 'chrome_installer.dart'; diff --git a/lib/web_ui/dev/firefox.dart b/lib/web_ui/dev/firefox.dart index b0f1558981006c0aa7b4f5b64851412a4ea0c1ec..ccff1789d54090b2019c75a093e5c23089770207 100644 --- a/lib/web_ui/dev/firefox.dart +++ b/lib/web_ui/dev/firefox.dart @@ -9,7 +9,7 @@ import 'dart:io'; import 'package:pedantic/pedantic.dart'; import 'package:path/path.dart' as path; -import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports +import 'package:test_core/src/util/io.dart'; import 'browser.dart'; import 'common.dart'; diff --git a/lib/web_ui/dev/test_platform.dart b/lib/web_ui/dev/test_platform.dart index 8e181eab37e6083036871218d7bcd16bc20d59d8..5373adda1c7690fee40bee409f32e45ee2a9fbd3 100644 --- a/lib/web_ui/dev/test_platform.dart +++ b/lib/web_ui/dev/test_platform.dart @@ -25,18 +25,18 @@ import 'package:web_socket_channel/web_socket_channel.dart'; import 'package:web_test_utils/goldens.dart'; import 'package:web_test_utils/image_compare.dart'; -import 'package:test_api/src/backend/runtime.dart'; // ignore: implementation_imports -import 'package:test_api/src/backend/suite_platform.dart'; // ignore: implementation_imports -import 'package:test_core/src/runner/runner_suite.dart'; // ignore: implementation_imports -import 'package:test_core/src/runner/platform.dart'; // ignore: implementation_imports -import 'package:test_core/src/util/stack_trace_mapper.dart'; // ignore: implementation_imports -import 'package:test_api/src/utils.dart'; // ignore: implementation_imports -import 'package:test_core/src/runner/suite.dart'; // ignore: implementation_imports -import 'package:test_core/src/runner/plugin/platform_helpers.dart'; // ignore: implementation_imports -import 'package:test_core/src/runner/environment.dart'; // ignore: implementation_imports - -import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports -import 'package:test_core/src/runner/configuration.dart'; // ignore: implementation_imports +import 'package:test_api/src/backend/runtime.dart'; +import 'package:test_api/src/backend/suite_platform.dart'; +import 'package:test_core/src/runner/runner_suite.dart'; +import 'package:test_core/src/runner/platform.dart'; +import 'package:test_core/src/util/stack_trace_mapper.dart'; +import 'package:test_api/src/utils.dart'; +import 'package:test_core/src/runner/suite.dart'; +import 'package:test_core/src/runner/plugin/platform_helpers.dart'; +import 'package:test_core/src/runner/environment.dart'; + +import 'package:test_core/src/util/io.dart'; +import 'package:test_core/src/runner/configuration.dart'; import 'browser.dart'; import 'common.dart'; diff --git a/lib/web_ui/dev/test_runner.dart b/lib/web_ui/dev/test_runner.dart index e82dfdb7411f4625e5def2ba8cb17849f558bb1c..85280f26d0d65ca033d5332365df1898ae1829b4 100644 --- a/lib/web_ui/dev/test_runner.dart +++ b/lib/web_ui/dev/test_runner.dart @@ -11,10 +11,10 @@ import 'package:meta/meta.dart'; import 'package:path/path.dart' as path; import 'package:pool/pool.dart'; import 'package:test_core/src/runner/hack_register_platform.dart' - as hack; // ignore: implementation_imports -import 'package:test_api/src/backend/runtime.dart'; // ignore: implementation_imports + as hack; +import 'package:test_api/src/backend/runtime.dart'; import 'package:test_core/src/executable.dart' - as test; // ignore: implementation_imports + as test; import 'package:web_test_utils/goldens.dart'; import 'common.dart'; diff --git a/lib/web_ui/lib/src/engine.dart b/lib/web_ui/lib/src/engine.dart index 88556925b93fc1683f9942fb23cf82df85b8e9f5..9e2537f8a709740c3afa30744513c536081abe11 100644 --- a/lib/web_ui/lib/src/engine.dart +++ b/lib/web_ui/lib/src/engine.dart @@ -17,8 +17,8 @@ import 'dart:js_util' as js_util; import 'dart:math' as math; import 'dart:typed_data'; -import 'package:js/js.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:meta/meta.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:js/js.dart'; +import 'package:meta/meta.dart'; import '../ui.dart' as ui; diff --git a/lib/web_ui/lib/src/engine/bitmap_canvas.dart b/lib/web_ui/lib/src/engine/bitmap_canvas.dart index 628bddd3693993b54f8a847beb33080ee676db3e..a9fbd6368a6cad80d5b87f1feeca7a7d0c3ff28a 100644 --- a/lib/web_ui/lib/src/engine/bitmap_canvas.dart +++ b/lib/web_ui/lib/src/engine/bitmap_canvas.dart @@ -577,7 +577,7 @@ class BitmapCanvas extends EngineCanvas { String cssColor = paint.color == null ? '#000000' : colorToCssString( - paint.color)!; // ignore: unnecessary_null_comparison + paint.color)!; final double sigma = paint.maskFilter!.webOnlySigma; if (browserEngine == BrowserEngine.webkit && !isStroke) { // A bug in webkit leaves artifacts when this element is animated diff --git a/lib/web_ui/lib/src/engine/window.dart b/lib/web_ui/lib/src/engine/window.dart index c6e0ea62cda367d24aab055fdd4019d0ec7028c4..fe8b6b737b3ab8a4d65a33f0e0095e6456178a3f 100644 --- a/lib/web_ui/lib/src/engine/window.dart +++ b/lib/web_ui/lib/src/engine/window.dart @@ -272,7 +272,6 @@ typedef _JsSetUrlStrategy = void Function(JsUrlStrategy?); // // TODO: Add integration test https://github.com/flutter/flutter/issues/66852 @JS('_flutter_web_set_location_strategy') -// ignore: unused_element external set _jsSetUrlStrategy(_JsSetUrlStrategy? newJsSetUrlStrategy); UrlStrategy? _createDefaultUrlStrategy() { diff --git a/lib/web_ui/test/color_test.dart b/lib/web_ui/test/color_test.dart index d48ea0bef83cb249c432f71186f0b89fe066bd46..9718c261e79b22f3e665634abdbd5802b7a934dc 100644 --- a/lib/web_ui/test/color_test.dart +++ b/lib/web_ui/test/color_test.dart @@ -55,7 +55,7 @@ void testMain() { test('two colors are only == if they have the same runtime type', () { expect(const Color(123), equals(const Color(123))); expect(const Color(123), - equals(Color(123))); // ignore: prefer_const_constructors + equals(Color(123))); expect(const Color(123), isNot(equals(const Color(321)))); expect(const Color(123), isNot(equals(const NotAColor(123)))); expect(const NotAColor(123), isNot(equals(const Color(123)))); diff --git a/lib/web_ui/test/engine/path_metrics_test.dart b/lib/web_ui/test/engine/path_metrics_test.dart index a7091207533ce3d31427039d02e7cba4c58bbeb9..a8938f913d99f7c6d45df89a89125fc6582968ef 100644 --- a/lib/web_ui/test/engine/path_metrics_test.dart +++ b/lib/web_ui/test/engine/path_metrics_test.dart @@ -4,11 +4,11 @@ import 'dart:math' as math; -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:ui/ui.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; +import 'package:ui/ui.dart'; -import '../matchers.dart'; // ignore: import_of_legacy_library_into_null_safe +import '../matchers.dart'; const double kTolerance = 0.001; diff --git a/lib/web_ui/test/engine/surface/path/path_iterator_test.dart b/lib/web_ui/test/engine/surface/path/path_iterator_test.dart index f0c914330a8480c7173e20d2ae9b72cc7b40410d..3e4c21e029930a8f23310a9eef3f0220910d7355 100644 --- a/lib/web_ui/test/engine/surface/path/path_iterator_test.dart +++ b/lib/web_ui/test/engine/surface/path/path_iterator_test.dart @@ -5,8 +5,8 @@ import 'dart:typed_data'; import 'package:ui/src/engine.dart'; -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; void main() { internalBootstrapBrowserTest(() => testMain); diff --git a/lib/web_ui/test/engine/surface/path/path_winding_test.dart b/lib/web_ui/test/engine/surface/path/path_winding_test.dart index 941da7134370405352d41d1cc05cd8baea37750f..f74a112ee9c73823ebb7f71d63ebc69bcce11f75 100644 --- a/lib/web_ui/test/engine/surface/path/path_winding_test.dart +++ b/lib/web_ui/test/engine/surface/path/path_winding_test.dart @@ -5,8 +5,8 @@ // @dart = 2.12 import 'dart:math' as math; -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; import 'package:ui/ui.dart' hide window; import 'package:ui/src/engine.dart'; diff --git a/lib/web_ui/test/engine/ulps_test.dart b/lib/web_ui/test/engine/ulps_test.dart index 871efcd5387d5361ba13325ecc395223ccb910db..d0a26c45faad7a478985c5108902a7fd8cb63bcc 100644 --- a/lib/web_ui/test/engine/ulps_test.dart +++ b/lib/web_ui/test/engine/ulps_test.dart @@ -3,8 +3,8 @@ // found in the LICENSE file. import 'dart:typed_data'; -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; import 'package:ui/src/engine.dart'; void main() { diff --git a/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart b/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart index 1e6f66e627e2f943a2d50f09ac210268f69c3a77..17ab3e21264044fa7d0de2dd382ffb2d4819f5ae 100644 --- a/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart +++ b/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart @@ -6,12 +6,12 @@ import 'dart:html' as html; import 'dart:js_util' as js_util; -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; import 'package:ui/ui.dart'; import 'package:ui/src/engine.dart' hide PhysicalShapeEngineLayer; -import 'package:web_engine_tester/golden_tester.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:web_engine_tester/golden_tester.dart'; final Rect region = Rect.fromLTWH(0, 0, 500, 500); diff --git a/lib/web_ui/test/lerp_test.dart b/lib/web_ui/test/lerp_test.dart index 1d458d3fa7d7a414d9600399640c9318af7c111a..026b42ee95dd25587a4c48f045a2182e07e6608e 100644 --- a/lib/web_ui/test/lerp_test.dart +++ b/lib/web_ui/test/lerp_test.dart @@ -3,8 +3,8 @@ // found in the LICENSE file. // @dart = 2.12 -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; import 'package:ui/ui.dart'; diff --git a/lib/web_ui/test/path_test.dart b/lib/web_ui/test/path_test.dart index da3d77397201f45e53dcd04b173d7b96cbe252e1..cc1eb2cfb2cda066da4b7393cf986cd3faee4405 100644 --- a/lib/web_ui/test/path_test.dart +++ b/lib/web_ui/test/path_test.dart @@ -7,12 +7,12 @@ import 'dart:js_util' as js_util; import 'dart:html' as html; import 'dart:typed_data'; -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; import 'package:ui/ui.dart' hide window; import 'package:ui/src/engine.dart'; -import 'matchers.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'matchers.dart'; void main() { internalBootstrapBrowserTest(() => testMain); diff --git a/lib/web_ui/test/text/line_breaker_test.dart b/lib/web_ui/test/text/line_breaker_test.dart index 6f8a41706a57413083da349a4dbc40c3f459f881..4fe59681ef57c51e4ae0d1699b95b4bffc7f539e 100644 --- a/lib/web_ui/test/text/line_breaker_test.dart +++ b/lib/web_ui/test/text/line_breaker_test.dart @@ -3,8 +3,8 @@ // found in the LICENSE file. // @dart = 2.12 -import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe -import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe +import 'package:test/bootstrap/browser.dart'; +import 'package:test/test.dart'; import 'package:ui/src/engine.dart'; import 'package:ui/ui.dart';