From 7e37080ec0d447d1a126e5fba06f73a4208ce1ea Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Fri, 19 Apr 2019 10:01:44 -0700 Subject: [PATCH] Allow specifying the Mac SDK path as an environment variable to //flutter/tools/gn (#8643) As long as the Mac SDK is i386 ready, engine developers should be able to use the latest version of Xcode to build all artifacts. This issue goes away when gen_snapshot migrates to x64. --- tools/gn | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/gn b/tools/gn index c589e82e0..ce9b7a6e8 100755 --- a/tools/gn +++ b/tools/gn @@ -237,6 +237,8 @@ def to_gn_args(args): if sys.platform == 'darwin': gn_args['mac_sdk_path'] = args.mac_sdk_path + if gn_args['mac_sdk_path'] == '': + gn_args['mac_sdk_path'] = os.getenv('FLUTTER_MAC_SDK_PATH', '') return gn_args @@ -294,7 +296,8 @@ def parse_args(args): parser.add_argument('--no-full-dart-sdk', dest='full_dart_sdk', action='store_false') parser.add_argument('--mac-sdk-path', default='', type=str, - help='On the mac, the SDK is inferred from the Xcode location unless this flag is specified.') + help='On the mac, the SDK is inferred from the Xcode location unless this flag is specified. ' + + ' Setting the FLUTTER_MAC_SDK_PATH environment variable achieves the same effect.') return parser.parse_args(args) -- GitLab