From 988ada3ce97c62ef9793a22aee977940e4ef4831 Mon Sep 17 00:00:00 2001 From: Ahmed Ashour Date: Thu, 21 Mar 2019 15:16:33 +0100 Subject: [PATCH] style: remove unneeded casts (PR #481) As detected by Eclipse, and the test case doesn't depend on the explicit casting. --- .../src/main/java/jadx/core/xmlgen/entry/ValuesParser.java | 2 +- jadx-gui/src/main/java/jadx/gui/JadxWrapper.java | 2 +- jadx-samples/src/main/java/jadx/samples/TestCF4.java | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java b/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java index ed02114a..1710e18a 100644 --- a/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java +++ b/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java @@ -215,7 +215,7 @@ public class ValuesParser extends ParserConstants { } private static String floatToString(float value) { - return doubleToString((double) value); + return doubleToString(value); } public static Map getAndroidResMap() { diff --git a/jadx-gui/src/main/java/jadx/gui/JadxWrapper.java b/jadx-gui/src/main/java/jadx/gui/JadxWrapper.java index 69bd8210..539a90af 100644 --- a/jadx-gui/src/main/java/jadx/gui/JadxWrapper.java +++ b/jadx-gui/src/main/java/jadx/gui/JadxWrapper.java @@ -53,7 +53,7 @@ public class JadxWrapper { while (ex.isTerminating()) { long total = ex.getTaskCount(); long done = ex.getCompletedTaskCount(); - progressMonitor.setProgress((int) (done * 100.0 / (double) total)); + progressMonitor.setProgress((int) (done * 100.0 / total)); Thread.sleep(500); } progressMonitor.close(); diff --git a/jadx-samples/src/main/java/jadx/samples/TestCF4.java b/jadx-samples/src/main/java/jadx/samples/TestCF4.java index 63048203..fa5fd7a7 100644 --- a/jadx-samples/src/main/java/jadx/samples/TestCF4.java +++ b/jadx-samples/src/main/java/jadx/samples/TestCF4.java @@ -21,13 +21,13 @@ public class TestCF4 extends AbstractTest { f = null; c = 2; testComplexIf("abcdef", 0); - assertEquals(c, (int) 'c'); + assertEquals(c, 'c'); d = ""; f = null; c = 0; testComplexIf("abcdef", 0); - assertEquals(c, (int) 'a'); + assertEquals(c, 'a'); d = ""; f = "1"; -- GitLab