diff --git a/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/AppNamespaceService.java b/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/AppNamespaceService.java index 86681f6e5973a6f913b48e7303eebd4d57636f26..be62ab8435e48b67927b1fb90ab55f055ecd6051 100644 --- a/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/AppNamespaceService.java +++ b/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/AppNamespaceService.java @@ -9,6 +9,7 @@ import org.springframework.transaction.annotation.Transactional; import com.ctrip.apollo.biz.entity.AppNamespace; import com.ctrip.apollo.biz.entity.Audit; import com.ctrip.apollo.biz.repository.AppNamespaceRepository; +import com.ctrip.apollo.core.ConfigConsts; import com.ctrip.apollo.core.exception.ServiceException; @Service @@ -33,7 +34,7 @@ public class AppNamespaceService { } AppNamespace appNs = new AppNamespace(); appNs.setAppId(appId); - appNs.setName(appId); + appNs.setName(ConfigConsts.NAMESPACE_DEFAULT); appNs.setComment("default app namespace"); appNs.setDataChangeCreatedBy(createBy); appNs.setDataChangeLastModifiedBy(createBy); diff --git a/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/NamespaceService.java b/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/NamespaceService.java index 93433c5b52a79004e4d9bfd6e69ade6886575701..46086d18371647655ba1099850d91680da3ea098 100644 --- a/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/NamespaceService.java +++ b/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/NamespaceService.java @@ -91,7 +91,7 @@ public class NamespaceService { Namespace ns = new Namespace(); ns.setAppId(appId); ns.setClusterName(ConfigConsts.CLUSTER_NAME_DEFAULT); - ns.setNamespaceName(appId); + ns.setNamespaceName(ConfigConsts.NAMESPACE_DEFAULT); ns.setDataChangeCreatedBy(createBy); ns.setDataChangeLastModifiedBy(createBy); namespaceRepository.save(ns); diff --git a/apollo-biz/src/test/java/com/ctrip/apollo/biz/service/AdminServiceTest.java b/apollo-biz/src/test/java/com/ctrip/apollo/biz/service/AdminServiceTest.java index bff5ae75d2805d9aeabc7a37211f597384050372..01e409206b4529db7a17db47bdd488d129049895 100644 --- a/apollo-biz/src/test/java/com/ctrip/apollo/biz/service/AdminServiceTest.java +++ b/apollo-biz/src/test/java/com/ctrip/apollo/biz/service/AdminServiceTest.java @@ -64,7 +64,7 @@ public class AdminServiceTest { List namespaces = namespaceService.findNamespaces(appId, clusters.get(0).getName()); Assert.assertEquals(1, namespaces.size()); - Assert.assertEquals(appId, namespaces.get(0).getNamespaceName()); + Assert.assertEquals(ConfigConsts.NAMESPACE_DEFAULT, namespaces.get(0).getNamespaceName()); List audits = auditService.findByOwner(owner); Assert.assertEquals(4, audits.size()); diff --git a/apollo-portal/src/main/java/com/ctrip/apollo/portal/service/ServiceLocator.java b/apollo-portal/src/main/java/com/ctrip/apollo/portal/service/ServiceLocator.java index 192f134d4f936d556eed0fd295ea2e3e23d128a4..629f172f6d917214f0b2d00e9c288620459d512d 100644 --- a/apollo-portal/src/main/java/com/ctrip/apollo/portal/service/ServiceLocator.java +++ b/apollo-portal/src/main/java/com/ctrip/apollo/portal/service/ServiceLocator.java @@ -41,18 +41,18 @@ public class ServiceLocator { public ServiceDTO getAdminService(Env env) throws ServiceException { List services = getServices(env, "admin"); - if (services.size() == 0) { + if (services == null || services.size() == 0) { throw new ServiceException("No available admin service"); } - return services.get(adminCallCounts.getAndIncrement() % services.size()); + return services.get(Math.abs(adminCallCounts.getAndIncrement()) % services.size()); } public ServiceDTO getConfigService(Env env) throws ServiceException { List services = getServices(env, "config"); - if (services.size() == 0) { + if (services == null || services.size() == 0) { throw new ServiceException("No available config service"); } - return services.get(configCallCounts.getAndIncrement() % services.size()); + return services.get(Math.abs(configCallCounts.getAndIncrement()) % services.size()); } private List getServices(Env env, String serviceUrl) {