diff --git a/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ItemController.java b/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ItemController.java index bfc65e1b553d3ff2aa592e951ad60c1432275e85..ddeb9865f5be42f58d913f07357d41d0a14e0ca2 100644 --- a/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ItemController.java +++ b/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ItemController.java @@ -68,6 +68,9 @@ public class ItemController { @RequestBody ItemDTO item) { checkModel(isValidItem(item)); + String username = userInfoHolder.getUser().getUserId(); + item.setDataChangeLastModifiedBy(username); + configService.updateItem(appId, Env.valueOf(env), clusterName, namespaceName, item); } diff --git a/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/ItemService.java b/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/ItemService.java index b627f4b90789df3fbb4a56b1075ec9f58b184295..e6da8a37b38eabda5443c214c678e1685f15653b 100644 --- a/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/ItemService.java +++ b/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/ItemService.java @@ -99,10 +99,6 @@ public class ItemService { } public void updateItem(String appId, Env env, String clusterName, String namespaceName, ItemDTO item) { - if (StringUtils.isEmpty(item.getDataChangeLastModifiedBy())) { - String username = userInfoHolder.getUser().getUserId(); - item.setDataChangeLastModifiedBy(username); - } itemAPI.updateItem(appId, env, clusterName, namespaceName, item.getId(), item); }