From e8ee9dc7f86e3828c48641b4bff7a1253548edab Mon Sep 17 00:00:00 2001
From: yuyang18 <reyoung@126.com>
Date: Mon, 9 Jul 2018 14:28:22 +0800
Subject: [PATCH] Several Polish

---
 paddle/fluid/framework/reader.cc                  |  2 +-
 paddle/fluid/framework/reader.h                   | 15 ++++-----------
 .../fluid/operators/reader/create_py_reader_op.cc |  4 ++--
 .../reader/create_recordio_file_reader_op.cc      |  5 ++---
 4 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/paddle/fluid/framework/reader.cc b/paddle/fluid/framework/reader.cc
index 3231b2ab27..924bbd32bd 100644
--- a/paddle/fluid/framework/reader.cc
+++ b/paddle/fluid/framework/reader.cc
@@ -36,7 +36,7 @@ void ReaderBase::Start() {
   }
 }
 
-ReaderBase::~ReaderBase() {}
+ReaderBase::~ReaderBase() { Shutdown(); }
 
 }  // namespace framework
 }  // namespace paddle
diff --git a/paddle/fluid/framework/reader.h b/paddle/fluid/framework/reader.h
index 9dc5fce4aa..51fc887f34 100644
--- a/paddle/fluid/framework/reader.h
+++ b/paddle/fluid/framework/reader.h
@@ -39,9 +39,9 @@ class ReaderBase {
  protected:
   virtual void ReadNextImpl(std::vector<LoDTensor>* out) = 0;
 
-  virtual void ShutdownImpl() = 0;
+  virtual void ShutdownImpl() {}
 
-  virtual void StartImpl() = 0;
+  virtual void StartImpl() {}
 
   ReaderStatus status_{kRunning};
 };
@@ -61,15 +61,8 @@ class DecoratedReader : public ReaderBase {
   std::shared_ptr<ReaderBase> reader_;
 };
 
-class FileReader : public ReaderBase {
- public:
-  FileReader() : ReaderBase() {}
-
- protected:
-  void ShutdownImpl() override {}
-
-  void StartImpl() override {}
-};
+// FileReader is just a conceptual class.
+class FileReader : public ReaderBase {};
 
 // The ReaderHolder is used as reader' unified wrapper,
 // making it easier to access different type reader in Variables.
diff --git a/paddle/fluid/operators/reader/create_py_reader_op.cc b/paddle/fluid/operators/reader/create_py_reader_op.cc
index 9b4c6412e6..fb7a96cb73 100644
--- a/paddle/fluid/operators/reader/create_py_reader_op.cc
+++ b/paddle/fluid/operators/reader/create_py_reader_op.cc
@@ -56,8 +56,8 @@ class CreatePyReaderOp : public framework::OperatorBase {
 
     const std::string& queue_name = Input("blocking_queue");
     auto* queue_holder_var = scope.FindVar(queue_name);
-    PADDLE_ENFORCE(
-        queue_holder_var != nullptr,
+    PADDLE_ENFORCE_NOT_NULL(
+        queue_holder_var,
         "No LoDTensorBlockingQueueHolder variable with name %s found",
         queue_name);
     auto* queue_holder =
diff --git a/paddle/fluid/operators/reader/create_recordio_file_reader_op.cc b/paddle/fluid/operators/reader/create_recordio_file_reader_op.cc
index 66f209b04e..61d94cfbd3 100644
--- a/paddle/fluid/operators/reader/create_recordio_file_reader_op.cc
+++ b/paddle/fluid/operators/reader/create_recordio_file_reader_op.cc
@@ -22,8 +22,7 @@ template <bool ThreadSafe>
 class RecordIOFileReader : public framework::FileReader {
  public:
   explicit RecordIOFileReader(const std::string& filename)
-      : FileReader(),
-        scanner_(filename),
+      : scanner_(filename),
         dev_ctx_(*platform::DeviceContextPool::Instance().Get(
             platform::CPUPlace())) {
     if (ThreadSafe) {
@@ -42,7 +41,7 @@ class RecordIOFileReader : public framework::FileReader {
     }
   }
 
-  void ShutdownImpl() override { scanner_.Reset(); }
+  void StartImpl() override { scanner_.Reset(); }
 
  private:
   std::unique_ptr<std::mutex> mutex_;
-- 
GitLab