From 3b8dd9ebbd5eee808d8fa891c2a91f4bd1680910 Mon Sep 17 00:00:00 2001
From: Qiao Longfei <qiaolongfei@baidu.com>
Date: Wed, 7 Nov 2018 12:41:50 +0800
Subject: [PATCH] optimize code test=develop

---
 paddle/fluid/operators/distributed/grpc_variable_response.cc | 4 ----
 paddle/fluid/operators/distributed/rpc_server.h              | 2 --
 paddle/fluid/operators/distributed/variable_response.cc      | 3 +++
 paddle/fluid/operators/distributed/variable_response.h       | 2 ++
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/paddle/fluid/operators/distributed/grpc_variable_response.cc b/paddle/fluid/operators/distributed/grpc_variable_response.cc
index 7076bae205..d6d219d436 100644
--- a/paddle/fluid/operators/distributed/grpc_variable_response.cc
+++ b/paddle/fluid/operators/distributed/grpc_variable_response.cc
@@ -22,9 +22,6 @@
 #include "paddle/fluid/operators/distributed/grpc_variable_response.h"
 #include "paddle/fluid/platform/profiler.h"
 
-DEFINE_string(rpc_server_profile_path, "/tmp/profile_ps",
-              "the profile log file path");
-
 namespace paddle {
 namespace operators {
 namespace distributed {
@@ -289,7 +286,6 @@ int GRPCVariableResponse::Parse(Source* source) {
           platform::EnableProfiler(platform::ProfilerState::kCPU);
         } else if (profiling == platform::kDisableProfiler &&
                    platform::IsProfileEnabled()) {
-          // TODO(panyx0718): Should we allow to customize file dir.
           platform::DisableProfiler(
               platform::EventSortingKey::kDefault,
               string::Sprintf("%s_%lld", FLAGS_rpc_server_profile_path,
diff --git a/paddle/fluid/operators/distributed/rpc_server.h b/paddle/fluid/operators/distributed/rpc_server.h
index c6934f8ace..c78c5007a7 100644
--- a/paddle/fluid/operators/distributed/rpc_server.h
+++ b/paddle/fluid/operators/distributed/rpc_server.h
@@ -23,8 +23,6 @@
 
 #include "paddle/fluid/operators/distributed/request_handler.h"
 
-DECLARE_string(rpc_server_profile_path);
-
 namespace paddle {
 namespace operators {
 namespace distributed {
diff --git a/paddle/fluid/operators/distributed/variable_response.cc b/paddle/fluid/operators/distributed/variable_response.cc
index c4854d50b6..b2f73b67dc 100644
--- a/paddle/fluid/operators/distributed/variable_response.cc
+++ b/paddle/fluid/operators/distributed/variable_response.cc
@@ -16,6 +16,9 @@
 #include <vector>
 #include "paddle/fluid/operators/distributed/sendrecvop_utils.h"
 
+DEFINE_string(rpc_server_profile_path, "./profile_ps",
+              "the profile log file path");
+
 namespace paddle {
 namespace operators {
 namespace distributed {
diff --git a/paddle/fluid/operators/distributed/variable_response.h b/paddle/fluid/operators/distributed/variable_response.h
index f20a6038ce..4c7fcbbdfb 100644
--- a/paddle/fluid/operators/distributed/variable_response.h
+++ b/paddle/fluid/operators/distributed/variable_response.h
@@ -27,6 +27,8 @@
 #include "paddle/fluid/framework/tensor.h"
 #include "paddle/fluid/operators/distributed/send_recv.pb.h"
 
+DECLARE_string(rpc_server_profile_path);
+
 namespace paddle {
 namespace operators {
 namespace distributed {
-- 
GitLab