From 3b8dc4bac4a5f9f39baffb85f6f1268cd4fa430d Mon Sep 17 00:00:00 2001 From: shaowenchen Date: Mon, 25 May 2020 15:39:20 +0800 Subject: [PATCH] fix SecretRef nil Signed-off-by: shaowenchen --- pkg/kapis/resources/v1alpha2/handler.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/kapis/resources/v1alpha2/handler.go b/pkg/kapis/resources/v1alpha2/handler.go index 2ee6b2a8..44c2c235 100644 --- a/pkg/kapis/resources/v1alpha2/handler.go +++ b/pkg/kapis/resources/v1alpha2/handler.go @@ -274,8 +274,12 @@ func (r *resourceHandler) handleVerifyGitCredential(request *restful.Request, re api.HandleBadRequest(response, nil, err) return } - - err = r.gitVerifier.VerifyGitCredential(credential.RemoteUrl, credential.SecretRef.Namespace, credential.SecretRef.Name) + var namespace, secretName string + if credential.SecretRef != nil { + namespace = credential.SecretRef.Namespace + secretName = credential.SecretRef.Name + } + err = r.gitVerifier.VerifyGitCredential(credential.RemoteUrl, namespace, secretName) if err != nil { api.HandleBadRequest(response, nil, err) return -- GitLab