From e7f98c201c204b179f744b5eef357ceed0515a4a Mon Sep 17 00:00:00 2001
From: hjxilinx <hjxilinx@163.com>
Date: Fri, 10 Jan 2020 15:08:32 +0800
Subject: [PATCH] [tbase-1473]

---
 src/client/src/tscSql.c | 45 ++++++++++++++++++++++++++++++-----------
 1 file changed, 33 insertions(+), 12 deletions(-)

diff --git a/src/client/src/tscSql.c b/src/client/src/tscSql.c
index a597cc7c01..a0ed09fd0f 100644
--- a/src/client/src/tscSql.c
+++ b/src/client/src/tscSql.c
@@ -812,26 +812,47 @@ int taos_errno(TAOS *taos) {
   return code;
 }
 
+static bool validErrorCode(int32_t code) {
+  return code >= TSDB_CODE_SUCCESS && code < TSDB_CODE_MAX_ERROR_CODE;
+}
+
+/*
+ * In case of invalid sql error, additional information is attached to explain
+ * why the sql is invalid
+ */
+static bool hasAdditionalErrorInfo(int32_t code, SSqlCmd* pCmd) {
+  if (code != TSDB_CODE_INVALID_SQL) {
+    return false;
+  }
+
+  size_t len = strlen(pCmd->payload);
+  
+  char* z = NULL;
+  if (len > 0) {
+    z = strstr (pCmd->payload, "invalid sql");
+  }
+  
+  return z != NULL;
+}
+
 char *taos_errstr(TAOS *taos) {
   STscObj *pObj = (STscObj *)taos;
   uint8_t  code;
 
   if (pObj == NULL || pObj->signature != pObj) return tsError[globalCode];
 
-  if ((int8_t)(pObj->pSql->res.code) == -1)
-    code = TSDB_CODE_OTHERS;
-  else
-    code = pObj->pSql->res.code;
+  SSqlObj* pSql = pObj->pSql;
+  
+  if (validErrorCode(pSql->res.code)) {
+    code = pSql->res.code;
+  } else {
+    code = TSDB_CODE_OTHERS;  //unknown error
+  }
 
-  // for invalid sql, additional information is attached to explain why the sql is invalid
-  if (code == TSDB_CODE_INVALID_SQL) {
-    return pObj->pSql->cmd.payload;
+  if (hasAdditionalErrorInfo(code, &pSql->cmd)) {
+    return pSql->cmd.payload;
   } else {
-    if (code < 0 || code > TSDB_CODE_MAX_ERROR_CODE) {
-      return tsError[TSDB_CODE_SUCCESS];
-    } else {
-      return tsError[code];
-    }
+    return tsError[code];
   }
 }
 
-- 
GitLab