- 30 3月, 2019 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- I feel `i18n_customize_full_messages` explains the meaning of the config better. - Followup of https://github.com/rails/rails/pull/32956
-
- 29 3月, 2019 5 次提交
-
-
由 Kasper Timm Hansen 提交于
Fix annotated typo
-
由 Prathamesh Sonpatki 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
Display a more helpful error message when an ERB template has a Ruby syntax error.
-
- 28 3月, 2019 10 次提交
-
-
由 Matthew Draper 提交于
sub, sub!, gsub, and gsub! should set back references
-
由 Ryuta Kamizono 提交于
[ci skip] Fixed testing guides typo `fourty` -> `forty`
-
由 Shailesh Kalamkar 提交于
-
由 Rafael França 提交于
Fix bug in Range comparisons when comparing to excluded-end Range
-
由 Owen Stephens 提交于
Before: ```ruby (1..10).cover?(1...11) => false ``` After: ```ruby (1..10).cover?(1...11) => true ``` See https://git.io/fjTtz for the commit against Ruby core that added support for Range arguments, with similar handling of this case.
-
由 Rafael França 提交于
Remove :all symbol from Mime::ALL
-
由 John Hawthorn 提交于
.all isn't a valid file extension, so it shouldn't used as a symbol. This also makes Mime::ALL better match how */* is parsed from an Accept header.
-
由 Rafael França 提交于
Prohibit sneaky custom params from being drawn (Fix #30467)
-
由 Ryuta Kamizono 提交于
Fix preloader to never reset associations in case they are already loaded
-
由 Matthew Draper 提交于
Stop encoding in secure_compare for speedup
-
- 27 3月, 2019 13 次提交
-
-
由 Ryuta Kamizono 提交于
We have a test case for `collation_connection` session variable, so it should not be changed in any other test. Fixes #35458.
-
由 Rafael França 提交于
Aligned the order of the arguments of render_template and render_with_layout
-
由 Bart de Water 提交于
Hex encoding is base 16 which makes the original input twice as big. With this change less time need to be spent in fixed_length_secure_compare.
-
由 Ken Greeff 提交于
* Update active_record_migrations.md * Change year to match others [Ken Greeff + Rafael Mendonça França]
-
由 Ryuta Kamizono 提交于
Bump RuboCop to 0.66.0
-
由 Rafael França 提交于
Add the `Mime::Type::InvalidMimeType` error in the default rescue_response:
-
由 Koichi ITO 提交于
### Summary RuboCop 0.66.0 has been released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.66.0 And rubocop-0-66 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.84.0 RuboCop 0.66.0 fixed the false negative to indentation for modifier. And this PR applied the auto-correction fixed by it. https://github.com/rubocop-hq/rubocop/pull/6792 In addtion, this PR is also updating the following 4 gems that RuboCop depends on. - Update Psych gem ... https://github.com/rubocop-hq/rubocop/pull/6766 - Update Parser gem to 2.6.2.0 that supports Ruby 2.5.5 and 2.6.2 ... https://github.com/whitequark/parser/blob/v2.6.2.0/CHANGELOG.md#changelog - Remove powerpack gem ... https://github.com/rubocop-hq/rubocop/pull/6806 - Update unicode-display_width gem ... https://github.com/rubocop-hq/rubocop/pull/6813
-
由 Rafael França 提交于
Deprecate custom patterns for PathResolver
-
由 John Hawthorn 提交于
Custom glob patterns tie the implementation (Using Dir.glob) to the API we provide. It also doesn't really work. extract_handler_and_format_and_variant expects the handler, format, and variant to be at the end of the template path, and in the same order as they are in the default pattern. This deprecates specifying a custom path for FileSystemResolver and removes the pattern argument of OptimizedFileSystemResolver#initialize, which does not work with a custom pattern.
-
由 Xavier Noria 提交于
Was just pushed.
-
由 Xavier Noria 提交于
-
由 Prathamesh Sonpatki 提交于
-
由 Shigeyuki-fukuda 提交于
-
- 26 3月, 2019 10 次提交
-
-
由 Matthew Draper 提交于
Use weak references in descendants tracker
-
由 Josua Schmid 提交于
After this change it's not possible anymore to configure routes like this: routes.draw do resources :users, param: "name/:sneaky" end Fixes #30467.
-
由 Edgars Beigarts 提交于
It allows anonymous subclasses to be garbage collected.
-
由 Xavier Noria 提交于
Grammar error
-
由 Sergio 提交于
-
由 Vipul A M 提交于
Add default value `ActiveSupport::Deprecation.silenced` [ci skip]
-
由 Ryuta Kamizono 提交于
`TRUNCATE TABLE posts` also resets `AUTO_INCREMENT`. If newly created a post, it is wrongly associated with remaining tagging records. To un-associate remaining tagging record, use `post.create_tagging!` instead. Fixes #35751.
-
由 Ryuta Kamizono 提交于
Use `assert_queries(0)` instead of `assert_no_queries`
-
由 Yasuo Honda 提交于
Fix #35665 ```ruby $ ARCONN=mysql2 bin/test test/cases/scoping/named_scoping_test.rb test/cases/tasks/database_tasks_test.rb test/cases/associations/cascaded_eager_loading_test.rb test/cases/associations/eager_singularization_test.rb -n "/^(?:NamedScopingTest#(?:test_many_should_not_fire_query_if_scope_loaded)|ActiveRecord::DatabaseTasksDumpSchemaCacheTest#(?:test_dump_schema_cache)|CascadedEagerLoadingTest#(?:test_eager_association_loading_with_has_many_sti_and_subclasses)|EagerSingularizationTest#(?:test_eager_no_extra_singularization_has_many_through_belongs_to))$/" --seed 16818 Using mysql2 Run options: -n "/^(?:NamedScopingTest#(?:test_many_should_not_fire_query_if_scope_loaded)|ActiveRecord::DatabaseTasksDumpSchemaCacheTest#(?:test_dump_schema_cache)|CascadedEagerLoadingTest#(?:test_eager_association_loading_with_has_many_sti_and_subclasses)|EagerSingularizationTest#(?:test_eager_no_extra_singularization_has_many_through_belongs_to))$/" --seed 16818 ...F Failure: CascadedEagerLoadingTest#test_eager_association_loading_with_has_many_sti_and_subclasses [/home/yahonda/git/rails/activerecord/test/cases/associations/cascaded_eager_loading_test.rb:124]: 1 instead of 0 queries were executed. Queries: SHOW FULL FIELDS FROM `topics`. Expected: 0 Actual: 1 bin/test test/cases/associations/cascaded_eager_loading_test.rb:119 Finished in 6.894609s, 0.5802 runs/s, 1.0153 assertions/s. 4 runs, 7 assertions, 1 failures, 0 errors, 0 skips $ ```
-
由 Edouard CHIN 提交于
- https://github.com/rails/rails/pull/35604 introduced a vulnerability fix to raise an error in case the `HTTP_ACCEPT` headers contains malformated mime type. This will cause applications to throw a 500 if a User Agent sends an invalid header. This PR adds the `InvalidMimeType` in the default `rescue_responses` from the ExceptionWrapper and will return a 406. I looked up the HTTP/1.1 RFC and it doesn't stand what should be returned when the UA sends malformated mime type. Decided to get 406 as it seemed to be the status the better suited for this.
-
- 25 3月, 2019 1 次提交
-
-
由 soartec-lab 提交于
-