From f4bfacb24fbe17c1010a46c2b2d7a15d44cf1918 Mon Sep 17 00:00:00 2001 From: Nicholas Seckar Date: Thu, 7 Jul 2005 19:51:20 +0000 Subject: [PATCH] Enable routes to recognize uppercase controller names. Closes #1635 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- actionpack/lib/action_controller/routing.rb | 2 +- actionpack/test/controller/routing_test.rb | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/actionpack/lib/action_controller/routing.rb b/actionpack/lib/action_controller/routing.rb index 8673412401..1a50eb488d 100644 --- a/actionpack/lib/action_controller/routing.rb +++ b/actionpack/lib/action_controller/routing.rb @@ -210,7 +210,7 @@ def traverse_to_controller(segments, start_at = 0) mod_name = controller_name = segment = nil while index < length - return nil unless /^[a-z][a-z\d_]*$/ =~ (segment = segments[index]) + return nil unless /^[A-Za-z][A-Za-z\d_]*$/ =~ (segment = segments[index]) index += 1 mod_name = segment.camelize diff --git a/actionpack/test/controller/routing_test.rb b/actionpack/test/controller/routing_test.rb index 38b995dc6e..93d16c6f65 100644 --- a/actionpack/test/controller/routing_test.rb +++ b/actionpack/test/controller/routing_test.rb @@ -109,6 +109,9 @@ def self.const_available?(*args) class UserController end + + class NewsFeedController + end end end @@ -718,6 +721,15 @@ def test_backwards def test_action_expiry assert_equal ['/content', {}], rs.generate({:controller => 'content'}, {:controller => 'content', :action => 'show'}) end + + def test_recognition_with_uppercase_controller_name + assert_equal({'controller' => ::Controllers::ContentController, 'action' => 'index'}, rs.recognize_path(%w(Content))) + assert_equal({'controller' => ::Controllers::ContentController, 'action' => 'list'}, rs.recognize_path(%w(Content list))) + assert_equal({'controller' => ::Controllers::ContentController, 'action' => 'show', 'id' => '10'}, rs.recognize_path(%w(Content show 10))) + + assert_equal({'controller' => ::Controllers::Admin::NewsFeedController, 'action' => 'index'}, rs.recognize_path(%w(Admin NewsFeed))) + assert_equal({'controller' => ::Controllers::Admin::NewsFeedController, 'action' => 'index'}, rs.recognize_path(%w(Admin News_Feed))) + end end end -- GitLab