From eec24a16c74248cf224f5cf9b233b7ede6eeb340 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Thu, 8 Sep 2005 12:21:36 +0000 Subject: [PATCH] Fixed that Active Record would call SHOW FIELDS twice (or more) for the same model when the cached results were available #1947 [sd@notso.net] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activerecord/CHANGELOG | 4 +++- activerecord/lib/active_record/base.rb | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/activerecord/CHANGELOG b/activerecord/CHANGELOG index 2c60938bda..10b562362e 100644 --- a/activerecord/CHANGELOG +++ b/activerecord/CHANGELOG @@ -1,6 +1,8 @@ *SVN* -* Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block +* Fixed that Active Record would call SHOW FIELDS twice (or more) for the same model when the cached results were available #1947 [sd@notso.net] + +* Added log_level and use_silence parameter to ActiveRecord::Base.benchmark. The first controls at what level the benchmark statement will be logged (now as debug, instead of info) and the second that can be passed false to include all logging statements during the benchmark block/ * Make sure the schema_info table is created before querying the current version #1903 diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb index 64f248cf90..22870a5263 100755 --- a/activerecord/lib/active_record/base.rb +++ b/activerecord/lib/active_record/base.rb @@ -1389,7 +1389,7 @@ def interpolate_sql(sql, record = nil) # that a new instance, or one populated from a passed-in Hash, still has all the attributes # that instances loaded from the database would. def attributes_from_column_definition - connection.columns(self.class.table_name, "#{self.class.name} Columns").inject({}) do |attributes, column| + self.class.columns.inject({}) do |attributes, column| attributes[column.name] = column.default unless column.name == self.class.primary_key attributes end -- GitLab