Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
e3a4eb4b
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e3a4eb4b
编写于
12月 14, 2011
作者:
J
José Valim
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Close the response body on cascade pass, closes #3975.
上级
19bea9f1
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
24 addition
and
3 deletion
+24
-3
actionpack/lib/action_dispatch/middleware/debug_exceptions.rb
...onpack/lib/action_dispatch/middleware/debug_exceptions.rb
+2
-0
actionpack/test/dispatch/debug_exceptions_test.rb
actionpack/test/dispatch/debug_exceptions_test.rb
+22
-3
未找到文件。
actionpack/lib/action_dispatch/middleware/debug_exceptions.rb
浏览文件 @
e3a4eb4b
...
...
@@ -17,6 +17,8 @@ def call(env)
# TODO: Maybe this should be in the router itself
if
response
[
1
][
'X-Cascade'
]
==
'pass'
body
=
response
[
2
]
body
.
close
if
body
.
respond_to?
(
:close
)
raise
ActionController
::
RoutingError
,
"No route matches [
#{
env
[
'REQUEST_METHOD'
]
}
]
#{
env
[
'PATH_INFO'
].
inspect
}
"
end
rescue
Exception
=>
exception
...
...
actionpack/test/dispatch/debug_exceptions_test.rb
浏览文件 @
e3a4eb4b
...
...
@@ -3,8 +3,18 @@
class
DebugExceptionsTest
<
ActionDispatch
::
IntegrationTest
class
Boomer
attr_accessor
:closed
def
initialize
(
detailed
=
false
)
@detailed
=
detailed
@closed
=
false
end
def
each
end
def
close
@closed
=
true
end
def
call
(
env
)
...
...
@@ -12,7 +22,7 @@ def call(env)
req
=
ActionDispatch
::
Request
.
new
(
env
)
case
req
.
path
when
"/pass"
[
404
,
{
"X-Cascade"
=>
"pass"
},
[]
]
[
404
,
{
"X-Cascade"
=>
"pass"
},
self
]
when
"/not_found"
raise
ActionController
::
UnknownAction
when
"/runtime_error"
...
...
@@ -31,8 +41,8 @@ def call(env)
end
end
ProductionApp
=
ActionDispatch
::
DebugExceptions
.
new
(
(
Boomer
.
new
(
false
)
))
DevelopmentApp
=
ActionDispatch
::
DebugExceptions
.
new
(
(
Boomer
.
new
(
true
)
))
ProductionApp
=
ActionDispatch
::
DebugExceptions
.
new
(
Boomer
.
new
(
false
))
DevelopmentApp
=
ActionDispatch
::
DebugExceptions
.
new
(
Boomer
.
new
(
true
))
test
'skip diagnosis if not showing detailed exceptions'
do
@app
=
ProductionApp
...
...
@@ -55,6 +65,15 @@ def call(env)
end
end
test
'closes the response body on cascade pass'
do
boomer
=
Boomer
.
new
(
false
)
@app
=
ActionDispatch
::
DebugExceptions
.
new
(
boomer
)
assert_raise
ActionController
::
RoutingError
do
get
"/pass"
,
{},
{
'action_dispatch.show_exceptions'
=>
true
}
end
assert
boomer
.
closed
,
"Expected to close the response body"
end
test
"rescue with diagnostics message"
do
@app
=
DevelopmentApp
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录