提交 e072db77 编写于 作者: G Genadi Samokovarov

Enforce minimal web-console version for Rails 5

I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.

I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.

We may need to backport this for Rails 5.0.1.

Fixes #25899.
上级 cf5bc0dd
......@@ -35,7 +35,7 @@ group :development do
<%- if options.dev? || options.edge? -%>
gem 'web-console', github: 'rails/web-console'
<%- else -%>
gem 'web-console'
gem 'web-console', '>= 3.3.0'
<%- end -%>
<%- end -%>
<% if depend_on_listen? -%>
......
......@@ -574,7 +574,7 @@ def test_web_console_with_dev_option
assert_file "Gemfile" do |content|
assert_match(/gem 'web-console',\s+github: 'rails\/web-console'/, content)
assert_no_match(/\Agem 'web-console'\z/, content)
assert_no_match(/\Agem 'web-console', '>= 3.3.0'\z/, content)
end
end
......@@ -583,7 +583,7 @@ def test_web_console_with_edge_option
assert_file "Gemfile" do |content|
assert_match(/gem 'web-console',\s+github: 'rails\/web-console'/, content)
assert_no_match(/\Agem 'web-console'\z/, content)
assert_no_match(/\Agem 'web-console', '>= 3.3.0'\z/, content)
end
end
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册