From e04c4c08200a15cfbc7019358dbe41399fa258f9 Mon Sep 17 00:00:00 2001 From: Sean Griffin Date: Fri, 27 Jun 2014 13:07:25 -0600 Subject: [PATCH] Note that `_will_change!` is no longer needed for AR instances Leave the note for `ActiveModel`, since it can't yet detect mutations (hopefully we can change this in time for 4.2). However, we now detect mutations on all supported types in `ActiveRecord`, so we can note that `_will_change!` is no longer needed there. --- activemodel/lib/active_model/dirty.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/activemodel/lib/active_model/dirty.rb b/activemodel/lib/active_model/dirty.rb index 98ffffeb10..48dd54a7b0 100644 --- a/activemodel/lib/active_model/dirty.rb +++ b/activemodel/lib/active_model/dirty.rb @@ -84,9 +84,11 @@ module ActiveModel # person.changed # => ["name"] # person.changes # => {"name" => ["Bill", "Bob"]} # - # If an attribute is modified in-place then make use of [attribute_name]_will_change! - # to mark that the attribute is changing. Otherwise ActiveModel can't track - # changes to in-place attributes. + # If an attribute is modified in-place then make use of + # +[attribute_name]_will_change!+ to mark that the attribute is changing. + # Otherwise ActiveModel can't track changes to in-place attributes. Note + # that ActiveRecord can detect in-place modifications automatically. You do + # not need to call +[attribute_name]_will_change!+ on ActiveRecord models. # # person.name_will_change! # person.name_change # => ["Bill", "Bill"] -- GitLab