From dd731446587d6b97fbe0bcd73e226952d549f5ba Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Tue, 12 Jan 2016 14:22:02 -0800 Subject: [PATCH] remove `present?` calls Empty strings / data structures should be treated differently than nils. We don't really need these calls here (don't pass in blank strings). --- actionpack/lib/action_controller/test_case.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/actionpack/lib/action_controller/test_case.rb b/actionpack/lib/action_controller/test_case.rb index 81c7dfa3b2..b43bb9dc17 100644 --- a/actionpack/lib/action_controller/test_case.rb +++ b/actionpack/lib/action_controller/test_case.rb @@ -459,16 +459,16 @@ def process(action, *args) parameters = nil end - if parameters.present? || session.present? || flash.present? + if parameters || session || flash non_kwarg_request_warning end end - if body.present? + if body @request.set_header 'RAW_POST_DATA', body end - if http_method.present? + if http_method http_method = http_method.to_s.upcase else http_method = "GET" @@ -476,7 +476,7 @@ def process(action, *args) parameters ||= {} - if format.present? + if format parameters[:format] = format end -- GitLab