From b72e076dde06c7e9d357d4b2baf87c44f8cace79 Mon Sep 17 00:00:00 2001
From: Vipul A M <vipulnsward@gmail.com>
Date: Tue, 7 Jan 2014 19:00:55 +0530
Subject: [PATCH] Extract comparison array to a constant for the time being
 until removing the check completely.

---
 lib/arel/select_manager.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/arel/select_manager.rb b/lib/arel/select_manager.rb
index 60df12c700..5fbe642df0 100644
--- a/lib/arel/select_manager.rb
+++ b/lib/arel/select_manager.rb
@@ -2,6 +2,8 @@ module Arel
   class SelectManager < Arel::TreeManager
     include Arel::Crud
 
+    STRING_OR_SYMBOL_CLASS = [Symbol, String]
+
     def initialize engine, table = nil
       super(engine)
       @ast   = Nodes::SelectStatement.new
@@ -128,7 +130,7 @@ def project *projections
       # FIXME: converting these to SQLLiterals is probably not good, but
       # rails tests require it.
       @ctx.projections.concat projections.map { |x|
-        [Symbol, String].include?(x.class) ? SqlLiteral.new(x.to_s) : x
+        STRING_OR_SYMBOL_CLASS.include?(x.class) ? SqlLiteral.new(x.to_s) : x
       }
       self
     end
@@ -152,7 +154,7 @@ def distinct(value = true)
     def order *expr
       # FIXME: We SHOULD NOT be converting these to SqlLiteral automatically
       @ast.orders.concat expr.map { |x|
-        String === x || Symbol === x ? Nodes::SqlLiteral.new(x.to_s) : x
+        STRING_OR_SYMBOL_CLASS.include?(x.class) ? Nodes::SqlLiteral.new(x.to_s) : x
       }
       self
     end
-- 
GitLab