Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
b67f57d1
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
b67f57d1
编写于
7月 09, 2018
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Merge pull request #33280 from nkondratyev/fix/mysql-time-default-values
Fix default value for mysql time types with specified precision
上级
c46a33bf
变更
4
显示空白变更内容
内联
并排
Showing
4 changed file
with
33 addition
and
17 deletion
+33
-17
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+4
-0
activerecord/lib/active_record/connection_adapters/mysql/schema_statements.rb
...ive_record/connection_adapters/mysql/schema_statements.rb
+2
-2
activerecord/test/cases/defaults_test.rb
activerecord/test/cases/defaults_test.rb
+20
-10
activerecord/test/schema/mysql2_specific_schema.rb
activerecord/test/schema/mysql2_specific_schema.rb
+7
-5
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
b67f57d1
*
Fix default value for mysql time types with specified precision.
*Nikolay Kondratyev*
*
Fix
`touch`
option to behave consistently with
`Persistence#touch`
method.
*Ryuta Kamizono*
...
...
activerecord/lib/active_record/connection_adapters/mysql/schema_statements.rb
浏览文件 @
b67f57d1
...
...
@@ -80,8 +80,8 @@ def create_table_definition(*args)
def
new_column_from_field
(
table_name
,
field
)
type_metadata
=
fetch_type_metadata
(
field
[
:Type
],
field
[
:Extra
])
if
type_metadata
.
type
==
:datetime
&&
/\ACURRENT_TIMESTAMP(?:\(\))?\z/i
.
match?
(
field
[
:Default
])
default
,
default_function
=
nil
,
"CURRENT_TIMESTAMP"
if
type_metadata
.
type
==
:datetime
&&
/\ACURRENT_TIMESTAMP(?:\(
[0-6]?
\))?\z/i
.
match?
(
field
[
:Default
])
default
,
default_function
=
nil
,
field
[
:Default
]
else
default
,
default_function
=
field
[
:Default
],
nil
end
...
...
activerecord/test/cases/defaults_test.rb
浏览文件 @
b67f57d1
...
...
@@ -106,16 +106,25 @@ class PostgresqlDefaultExpressionTest < ActiveRecord::TestCase
class
MysqlDefaultExpressionTest
<
ActiveRecord
::
TestCase
include
SchemaDumpingHelper
if
ActiveRecord
::
Base
.
connection
.
version
>=
"5.6.0"
if
subsecond_precision_supported?
test
"schema dump datetime includes default expression"
do
output
=
dump_table_schema
(
"datetime_defaults"
)
assert_match
%r/t
\.
datetime
\s
+"modified_datetime",
\s
+default: -> { "CURRENT_TIMESTAMP
" }/
,
output
assert_match
%r/t
\.
datetime
\s
+"modified_datetime",
\s
+default: -> { "CURRENT_TIMESTAMP
(?:
\(\)
)?" }/i
,
output
end
test
"schema dump datetime includes precise default expression"
do
output
=
dump_table_schema
(
"datetime_defaults"
)
assert_match
%r/t
\.
datetime
\s
+"precise_datetime",.+default: -> { "CURRENT_TIMESTAMP
\(
6
\)
" }/i
,
output
end
test
"schema dump timestamp includes default expression"
do
output
=
dump_table_schema
(
"timestamp_defaults"
)
assert_match
%r/t
\.
timestamp
\s
+"modified_timestamp",
\s
+default: -> { "CURRENT_TIMESTAMP" }/
,
output
assert_match
%r/t
\.
timestamp
\s
+"modified_timestamp",
\s
+default: -> { "CURRENT_TIMESTAMP(?:
\(\)
)?" }/i
,
output
end
test
"schema dump timestamp includes precise default expression"
do
output
=
dump_table_schema
(
"timestamp_defaults"
)
assert_match
%r/t
\.
timestamp
\s
+"precise_timestamp",.+default: -> { "CURRENT_TIMESTAMP
\(
6
\)
" }/i
,
output
end
test
"schema dump timestamp without default expression"
do
...
...
@@ -123,6 +132,7 @@ class MysqlDefaultExpressionTest < ActiveRecord::TestCase
assert_match
%r/t
\.
timestamp
\s
+"nullable_timestamp"$/
,
output
end
end
end
class
DefaultsTestWithoutTransactionalFixtures
<
ActiveRecord
::
TestCase
# ActiveRecord::Base#create! (and #save and other related methods) will
...
...
activerecord/test/schema/mysql2_specific_schema.rb
浏览文件 @
b67f57d1
...
...
@@ -2,15 +2,17 @@
ActiveRecord
::
Schema
.
define
do
if
ActiveRecord
::
Base
.
connection
.
version
>=
"5.6.0"
if
subsecond_precision_supported?
create_table
:datetime_defaults
,
force:
true
do
|
t
|
t
.
datetime
:modified_datetime
,
default:
->
{
"CURRENT_TIMESTAMP"
}
end
t
.
datetime
:precise_datetime
,
precision:
6
,
default:
->
{
"CURRENT_TIMESTAMP(6)"
}
end
create_table
:timestamp_defaults
,
force:
true
do
|
t
|
t
.
timestamp
:nullable_timestamp
t
.
timestamp
:modified_timestamp
,
default:
->
{
"CURRENT_TIMESTAMP"
}
t
.
timestamp
:precise_timestamp
,
precision:
6
,
default:
->
{
"CURRENT_TIMESTAMP(6)"
}
end
end
create_table
:binary_fields
,
force:
true
do
|
t
|
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录