Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
a7628099
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a7628099
编写于
9月 25, 2015
作者:
S
Soutaro Matsumoto
提交者:
Sean Griffin
10月 20, 2015
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Qualify column names in calculation
Column names inserted via `group` have to be qualified with table name.
上级
d99db6b8
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
27 addition
and
1 deletion
+27
-1
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+7
-0
activerecord/lib/active_record/relation/calculations.rb
activerecord/lib/active_record/relation/calculations.rb
+1
-1
activerecord/test/cases/calculations_test.rb
activerecord/test/cases/calculations_test.rb
+19
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
a7628099
*
Qualify column name inserted by
`group`
in calculation
Giving `group` an unqualified column name now works, even if the relation
has `JOIN` with another table which also has a column of the name.
*Soutaro Matsumoto*
*
Don't cache prepared statements containing an IN clause or a SQL literal, as
these queries will change often and are unlikely to have a cache hit.
...
...
activerecord/lib/active_record/relation/calculations.rb
浏览文件 @
a7628099
...
...
@@ -297,7 +297,7 @@ def execute_grouped_calculation(operation, column_name, distinct) #:nodoc:
]
select_values
+=
select_values
unless
having_clause
.
empty?
select_values
.
concat
group_fields
.
zip
(
group_aliases
).
map
{
|
field
,
aliaz
|
select_values
.
concat
arel_columns
(
group_fields
)
.
zip
(
group_aliases
).
map
{
|
field
,
aliaz
|
if
field
.
respond_to?
(
:as
)
field
.
as
(
aliaz
)
else
...
...
activerecord/test/cases/calculations_test.rb
浏览文件 @
a7628099
...
...
@@ -102,6 +102,25 @@ def test_should_group_by_summed_field
assert_equal
60
,
c
[
2
]
end
def
test_should_generate_valid_sql_with_joins_and_group
assert_nothing_raised
ActiveRecord
::
StatementInvalid
do
AuditLog
.
joins
(
:developer
).
group
(
:id
).
count
end
end
def
test_should_calculate_against_given_relation
developer
=
Developer
.
create!
(
name:
"developer"
)
developer
.
audit_logs
.
create!
(
message:
"first log"
)
developer
.
audit_logs
.
create!
(
message:
"second log"
)
c
=
developer
.
audit_logs
.
joins
(
:developer
).
group
(
:id
).
count
assert_equal
developer
.
audit_logs
.
count
,
c
.
size
developer
.
audit_logs
.
each
do
|
log
|
assert_equal
1
,
c
[
log
.
id
]
end
end
def
test_should_order_by_grouped_field
c
=
Account
.
group
(
:firm_id
).
order
(
"firm_id"
).
sum
(
:credit_limit
)
assert_equal
[
1
,
2
,
6
,
9
],
c
.
keys
.
compact
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录