Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
9ce59f66
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
9ce59f66
编写于
6月 19, 2014
作者:
R
Rafael Mendonça França
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #15747 from sgrif/sg-trolololol-this-is-so-broken
Always update counter caches in memory when adding records
上级
84181514
e6690d37
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
56 addition
and
1 deletion
+56
-1
activerecord/lib/active_record/associations/has_many_association.rb
...rd/lib/active_record/associations/has_many_association.rb
+26
-0
activerecord/lib/active_record/associations/has_many_through_association.rb
...ctive_record/associations/has_many_through_association.rb
+0
-1
activerecord/test/cases/associations/has_many_associations_test.rb
...ord/test/cases/associations/has_many_associations_test.rb
+30
-0
未找到文件。
activerecord/lib/active_record/associations/has_many_association.rb
浏览文件 @
9ce59f66
...
...
@@ -83,6 +83,13 @@ def update_counter(difference, reflection = reflection())
if
has_cached_counter?
(
reflection
)
counter
=
cached_counter_attribute_name
(
reflection
)
owner
.
class
.
update_counters
(
owner
.
id
,
counter
=>
difference
)
update_counter_in_memory
(
difference
,
reflection
)
end
end
def
update_counter_in_memory
(
difference
,
reflection
=
reflection
())
if
has_cached_counter?
(
reflection
)
counter
=
cached_counter_attribute_name
(
reflection
)
owner
[
counter
]
+=
difference
owner
.
changed_attributes
.
delete
(
counter
)
# eww
end
...
...
@@ -137,6 +144,25 @@ def foreign_key_present?
false
end
end
def
concat_records
(
records
,
*
)
update_counter_if_success
(
super
,
records
.
length
)
end
def
_create_record
(
attributes
,
*
)
if
attributes
.
is_a?
(
Array
)
super
else
update_counter_if_success
(
super
,
1
)
end
end
def
update_counter_if_success
(
saved_successfully
,
difference
)
if
saved_successfully
update_counter_in_memory
(
difference
)
end
saved_successfully
end
end
end
end
activerecord/lib/active_record/associations/has_many_through_association.rb
浏览文件 @
9ce59f66
...
...
@@ -63,7 +63,6 @@ def insert_record(record, validate = true, raise = false)
end
save_through_record
(
record
)
update_counter
(
1
)
record
end
...
...
activerecord/test/cases/associations/has_many_associations_test.rb
浏览文件 @
9ce59f66
...
...
@@ -772,6 +772,36 @@ def test_deleting_updates_counter_cache
assert_equal
topic
.
replies
.
to_a
.
size
,
topic
.
replies_count
end
def
test_counter_cache_updates_in_memory_after_concat
topic
=
Topic
.
create
title:
"Zoom-zoom-zoom"
topic
.
replies
<<
Reply
.
create
(
title:
"re: zoom"
,
content:
"speedy quick!"
)
assert_equal
1
,
topic
.
replies_count
assert_equal
1
,
topic
.
replies
.
size
assert_equal
1
,
topic
.
reload
.
replies
.
size
end
def
test_counter_cache_updates_in_memory_after_create
topic
=
Topic
.
create
title:
"Zoom-zoom-zoom"
topic
.
replies
.
create!
(
title:
"re: zoom"
,
content:
"speedy quick!"
)
assert_equal
1
,
topic
.
replies_count
assert_equal
1
,
topic
.
replies
.
size
assert_equal
1
,
topic
.
reload
.
replies
.
size
end
def
test_counter_cache_updates_in_memory_after_create_with_array
topic
=
Topic
.
create
title:
"Zoom-zoom-zoom"
topic
.
replies
.
create!
([
{
title:
"re: zoom"
,
content:
"speedy quick!"
},
{
title:
"re: zoom 2"
,
content:
"OMG lol!"
},
])
assert_equal
2
,
topic
.
replies_count
assert_equal
2
,
topic
.
replies
.
size
assert_equal
2
,
topic
.
reload
.
replies
.
size
end
def
test_pushing_association_updates_counter_cache
topic
=
Topic
.
order
(
"id ASC"
).
first
reply
=
Reply
.
create!
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录