Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
8f59ffce
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
8f59ffce
编写于
12月 13, 2012
作者:
M
Matthew M. Boedicker
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Do not log the binding values for binary columns.
They tend to be large and not very useful in the log.
上级
fa3457dc
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
23 addition
and
1 deletion
+23
-1
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+4
-0
activerecord/lib/active_record/log_subscriber.rb
activerecord/lib/active_record/log_subscriber.rb
+11
-1
activerecord/test/cases/log_subscriber_test.rb
activerecord/test/cases/log_subscriber_test.rb
+8
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
8f59ffce
## Rails 4.0.0 (unreleased) ##
## Rails 4.0.0 (unreleased) ##
*
Do not log the binding values for binary columns.
*Matthew M. Boedicker*
*
Fix counter cache columns not updated when replacing
`has_many :through`
*
Fix counter cache columns not updated when replacing
`has_many :through`
associations.
associations.
...
...
activerecord/lib/active_record/log_subscriber.rb
浏览文件 @
8f59ffce
...
@@ -20,6 +20,16 @@ def initialize
...
@@ -20,6 +20,16 @@ def initialize
@odd_or_even
=
false
@odd_or_even
=
false
end
end
def
render_bind
(
column
,
value
)
if
column
.
type
==
:binary
rendered_value
=
"<
#{
value
.
bytesize
}
bytes of binary data>"
else
rendered_value
=
value
end
[
column
.
name
,
rendered_value
]
end
def
sql
(
event
)
def
sql
(
event
)
self
.
class
.
runtime
+=
event
.
duration
self
.
class
.
runtime
+=
event
.
duration
return
unless
logger
.
debug?
return
unless
logger
.
debug?
...
@@ -34,7 +44,7 @@ def sql(event)
...
@@ -34,7 +44,7 @@ def sql(event)
unless
(
payload
[
:binds
]
||
[]).
empty?
unless
(
payload
[
:binds
]
||
[]).
empty?
binds
=
" "
+
payload
[
:binds
].
map
{
|
col
,
v
|
binds
=
" "
+
payload
[
:binds
].
map
{
|
col
,
v
|
[
col
.
name
,
v
]
render_bind
(
col
,
v
)
}.
inspect
}.
inspect
end
end
...
...
activerecord/test/cases/log_subscriber_test.rb
浏览文件 @
8f59ffce
require
"cases/helper"
require
"cases/helper"
require
"models/binary"
require
"models/developer"
require
"models/developer"
require
"models/post"
require
"models/post"
require
"active_support/log_subscriber/test_helper"
require
"active_support/log_subscriber/test_helper"
...
@@ -100,4 +101,11 @@ def test_cached_queries_doesnt_log_when_level_is_not_debug
...
@@ -100,4 +101,11 @@ def test_cached_queries_doesnt_log_when_level_is_not_debug
def
test_initializes_runtime
def
test_initializes_runtime
Thread
.
new
{
assert_equal
0
,
ActiveRecord
::
LogSubscriber
.
runtime
}.
join
Thread
.
new
{
assert_equal
0
,
ActiveRecord
::
LogSubscriber
.
runtime
}.
join
end
end
def
test_binary_data_is_not_logged
Binary
.
create
(
:data
=>
'some binary data'
)
wait
assert_equal
3
,
@logger
.
logged
(
:debug
).
size
assert_match
(
/<16 bytes of binary data>/
,
@logger
.
logged
(
:debug
)[
-
2
])
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录