Remove some of the blank rescues from number helper. This makes the code...

Remove some of the blank rescues from number helper. This makes the code easier to understand, as you're not left wondering what the rescue is actually doing. This does not change documented/tested behaviour.
Signed-off-by: Nwycats <wycats@gmail.com>

actionpack/lib/action_view/helpers/number_helper.rb

@@ -28,14 +28,15 @@ module NumberHelper
       #  number_to_phone(1235551234, :country_code => 1, :extension => 1343, :delimiter => ".")
       #  => +1.123.555.1234 x 1343
       def number_to_phone(number, options = {})
-        number       = number.to_s.strip unless number.nil?
+        return nil if number.nil?
+
+        number       = number.to_s.strip
         options      = options.symbolize_keys
         area_code    = options[:area_code] || nil
         delimiter    = options[:delimiter] || "-"
         extension    = options[:extension].to_s.strip || nil
         country_code = options[:country_code] || nil
 
-        begin
         str = ""
         str << "+#{country_code}#{delimiter}" unless country_code.blank?
         str << if area_code
@@ -46,9 +47,6 @@ def number_to_phone(number, options = {})
         end
         str << " x #{extension}" unless extension.blank?
         str
-        rescue
-          number
-        end
       end
 
       # Formats a +number+ into a currency string (e.g., $13.65). You can customize the format
@@ -87,13 +85,14 @@ def number_to_currency(number, options = {})
         format    = options[:format]    || defaults[:format]
         separator = '' if precision == 0
 
-        begin
-          format.gsub(/%n/, number_with_precision(number,
+        value = number_with_precision(number,
           :precision => precision,
           :delimiter => delimiter,
           :separator => separator)
-          ).gsub(/%u/, unit).html_safe
-        rescue
+
+        if value
+          format.gsub(/%n/, value).gsub(/%u/, unit).html_safe
+        else
           number
         end
       end
@@ -122,14 +121,11 @@ def number_to_percentage(number, options = {})
         separator = options[:separator] || defaults[:separator]
         delimiter = options[:delimiter] || defaults[:delimiter]
 
-        begin
-          number_with_precision(number,
+        value = number_with_precision(number,
           :precision => precision,
           :separator => separator,
-            :delimiter => delimiter) + "%"
-        rescue
-          number
-        end
+          :delimiter => delimiter)
+        value ? value + "%" : number
       end
 
       # Formats a +number+ with grouped thousands using +delimiter+ (e.g., 12,324). You can
@@ -168,11 +164,11 @@ def number_with_delimiter(number, *args)
         delimiter ||= (options[:delimiter] || defaults[:delimiter])
         separator ||= (options[:separator] || defaults[:separator])
 
-        begin
         parts = number.to_s.split('.')
+        if parts[0]
           parts[0].gsub!(/(\d)(?=(\d\d\d)+(?!\d))/, "\\1#{delimiter}")
           parts.join(separator)
-        rescue
+        else
           number
         end
       end
@@ -216,11 +212,17 @@ def number_with_precision(number, *args)
         delimiter ||= (options[:delimiter] || defaults[:delimiter])
 
         begin
+          value = Float(number)
+        rescue ArgumentError, TypeError
+          value = nil
+        end
+
+        if value
           rounded_number = BigDecimal.new((Float(number) * (10 ** precision)).to_s).round.to_f / 10 ** precision
           number_with_delimiter("%01.#{precision}f" % rounded_number,
             :separator => separator,
             :delimiter => delimiter)
-        rescue
+        else
           number
         end
       end
@@ -293,7 +295,6 @@ def number_to_human_size(number, *args)
           unit_key = STORAGE_UNITS[exponent]
           unit = I18n.translate(:"number.human.storage_units.units.#{unit_key}", :locale => options[:locale], :count => number, :raise => true)
 
-          begin
           escaped_separator = Regexp.escape(separator)
           formatted_number = number_with_precision(number,
             :precision => precision,
@@ -301,9 +302,6 @@ def number_to_human_size(number, *args)
             :delimiter => delimiter
           ).sub(/(#{escaped_separator})(\d*[1-9])?0+\z/, '\1\2').sub(/#{escaped_separator}\z/, '')
           storage_units_format.gsub(/%n/, formatted_number).gsub(/%u/, unit)
-          rescue
-            number
-          end
         end
       end
     end