Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
847e9a95
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
847e9a95
编写于
12月 16, 2013
作者:
C
Cody Cutrer
提交者:
Cody Cutrer
12月 19, 2013
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fix default select when from is used
上级
e4cde5d5
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
26 addition
and
1 deletion
+26
-1
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+18
-0
activerecord/lib/active_record/relation/query_methods.rb
activerecord/lib/active_record/relation/query_methods.rb
+3
-1
activerecord/test/cases/relations_test.rb
activerecord/test/cases/relations_test.rb
+5
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
847e9a95
*
Improve the default select when from is used.
Previously, if you did something like Topic.from(:temp_topics), it
would generate SQL like:
SELECT topics.* FROM temp_topics;
Which is useless, cause obviously there's not a topics table to select
from. So one would always have to include a select to override the
default behavior. Now the default if you use from is just *:
SELECT * FROM temp_topics;
Which may not be what you want in all cases, but is at least usable
in some cases.
*Cody Cutrer*
*
Fix
`PostgreSQL`
insert to properly extract table name from multiline string SQL.
*
Fix
`PostgreSQL`
insert to properly extract table name from multiline string SQL.
Previously, executing an insert SQL in `PostgreSQL` with a command like this:
Previously, executing an insert SQL in `PostgreSQL` with a command like this:
...
...
activerecord/lib/active_record/relation/query_methods.rb
浏览文件 @
847e9a95
...
@@ -982,8 +982,10 @@ def build_joins(manager, joins)
...
@@ -982,8 +982,10 @@ def build_joins(manager, joins)
end
end
def
build_select
(
arel
,
selects
)
def
build_select
(
arel
,
selects
)
unless
selects
.
empty?
if
!
selects
.
empty?
arel
.
project
(
*
selects
)
arel
.
project
(
*
selects
)
elsif
from_value
arel
.
project
(
Arel
.
star
)
else
else
arel
.
project
(
@klass
.
arel_table
[
Arel
.
star
])
arel
.
project
(
@klass
.
arel_table
[
Arel
.
star
])
end
end
...
...
activerecord/test/cases/relations_test.rb
浏览文件 @
847e9a95
...
@@ -151,6 +151,11 @@ def test_finding_with_subquery_with_binds
...
@@ -151,6 +151,11 @@ def test_finding_with_subquery_with_binds
assert_equal
relation
.
to_a
,
Comment
.
select
(
'a.*'
).
from
(
relation
,
:a
).
to_a
assert_equal
relation
.
to_a
,
Comment
.
select
(
'a.*'
).
from
(
relation
,
:a
).
to_a
end
end
def
test_finding_with_subquery_without_select
relation
=
Topic
.
where
(
:approved
=>
true
)
assert_equal
relation
.
to_a
,
Topic
.
from
(
relation
).
to_a
end
def
test_finding_with_conditions
def
test_finding_with_conditions
assert_equal
[
"David"
],
Author
.
where
(
:name
=>
'David'
).
map
(
&
:name
)
assert_equal
[
"David"
],
Author
.
where
(
:name
=>
'David'
).
map
(
&
:name
)
assert_equal
[
'Mary'
],
Author
.
where
([
"name = ?"
,
'Mary'
]).
map
(
&
:name
)
assert_equal
[
'Mary'
],
Author
.
where
([
"name = ?"
,
'Mary'
]).
map
(
&
:name
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录