From 7f45c2d02a732cc724a021fd5907c1f00b7e1fe9 Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Fri, 17 Feb 2017 08:52:52 +0900 Subject: [PATCH] Add CHANGELOG entry for #27384 and #27762 --- activerecord/CHANGELOG.md | 4 ++++ activerecord/test/cases/primary_keys_test.rb | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 116363f2d9..c1f39958b7 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,7 @@ +* All integer-like PKs are autoincrement unless they have an explicit default. + + *Matthew Draper* + * Omit redundant `using: :btree` for schema dumping. *Ryuta Kamizono* diff --git a/activerecord/test/cases/primary_keys_test.rb b/activerecord/test/cases/primary_keys_test.rb index 98b9c91489..03c8644229 100644 --- a/activerecord/test/cases/primary_keys_test.rb +++ b/activerecord/test/cases/primary_keys_test.rb @@ -238,13 +238,13 @@ def teardown @connection.drop_table(:auto_increments, if_exists: true) end - def test_primary_key_with_auto_increment - @connection.create_table(:auto_increments, id: :integer, auto_increment: true, force: true) + def test_primary_key_with_integer + @connection.create_table(:auto_increments, id: :integer, force: true) assert_auto_incremented end - def test_primary_key_with_auto_increment_and_bigint - @connection.create_table(:auto_increments, id: :bigint, auto_increment: true, force: true) + def test_primary_key_with_bigint + @connection.create_table(:auto_increments, id: :bigint, force: true) assert_auto_incremented end -- GitLab