From 7f3cfb606730965be690859a49236cf581fd469b Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Mon, 10 Aug 2015 16:24:32 -0700 Subject: [PATCH] always cast `name` to a symbol, and never to_s it All callers of `action_path` interpolate the return value in to a string, so there is no need for the method to to_s it. to_sym on a symbol will return the same symbol, though I think `action_path` may always be called with a symbol so this might not be necessary. --- actionpack/lib/action_dispatch/routing/mapper.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/actionpack/lib/action_dispatch/routing/mapper.rb b/actionpack/lib/action_dispatch/routing/mapper.rb index 1c945dd496..c51be5d29f 100644 --- a/actionpack/lib/action_dispatch/routing/mapper.rb +++ b/actionpack/lib/action_dispatch/routing/mapper.rb @@ -1743,8 +1743,7 @@ def path_for_action(action, path) #:nodoc: end def action_path(name) #:nodoc: - name = name.to_sym if name.is_a?(String) - @scope[:path_names][name] || name.to_s + @scope[:path_names][name.to_sym] || name end def prefix_name_for_action(as, action) #:nodoc: -- GitLab