Revert "Explicitly exit with status "1" for create and drop failures"

This reverts commit 22f80ae5.

See
https://github.com/rails/rails/commit/22f80ae57b26907f662b7fd50a7270a6381e527e#commitcomment-4640676

Conflicts:
	activerecord/CHANGELOG.md

activerecord/CHANGELOG.md

@@ -2,10 +2,6 @@
 
     *Edo Balvers*
 
-*   Exit with non-zero status for failed database rake tasks.
-
-    *Jay Hayes*
-
 *   Added `ActiveRecord::Base.to_param` for convenient "pretty" URLs derived from a model's attribute or method.
 
     Example:

activerecord/lib/active_record/railties/databases.rake

@@ -8,48 +8,32 @@ db_namespace = namespace :db do
 
   namespace :create do
     task :all => :load_config do
-      begin
       ActiveRecord::Tasks::DatabaseTasks.create_all
-      rescue
-        exit(1)
-      end
     end
   end
 
   desc 'Create the database from DATABASE_URL or config/database.yml for the current Rails.env (use db:create:all to create all databases in the config)'
   task :create => [:load_config] do
-    begin
     if ENV['DATABASE_URL']
       ActiveRecord::Tasks::DatabaseTasks.create_database_url
     else
       ActiveRecord::Tasks::DatabaseTasks.create_current
     end
-    rescue
-      exit(1)
-    end
   end
 
   namespace :drop do
     task :all => :load_config do
-      begin
       ActiveRecord::Tasks::DatabaseTasks.drop_all
-      rescue
-        exit(1)
-      end
     end
   end
 
   desc 'Drops the database using DATABASE_URL or the current Rails.env (use db:drop:all to drop all databases)'
   task :drop => [:load_config] do
-    begin
     if ENV['DATABASE_URL']
       ActiveRecord::Tasks::DatabaseTasks.drop_database_url
     else
       ActiveRecord::Tasks::DatabaseTasks.drop_current
     end
-    rescue
-      exit(1)
-    end
   end
 
   desc "Migrate the database (options: VERSION=x, VERBOSE=false, SCOPE=blog)."

activerecord/lib/active_record/tasks/database_tasks.rb

@@ -69,11 +69,9 @@ def create(*arguments)
         class_for_adapter(configuration['adapter']).new(*arguments).create
       rescue DatabaseAlreadyExists
         $stderr.puts "#{configuration['database']} already exists"
-        raise
       rescue Exception => error
         $stderr.puts error, *(error.backtrace)
         $stderr.puts "Couldn't create database for #{configuration.inspect}"
-        raise
       end
 
       def create_all
@@ -97,7 +95,6 @@ def drop(*arguments)
       rescue Exception => error
         $stderr.puts error, *(error.backtrace)
         $stderr.puts "Couldn't drop #{configuration['database']}"
-        raise
       end
 
       def drop_all

activerecord/test/cases/tasks/mysql_rake_test.rb

@@ -62,11 +62,9 @@ def test_create_when_database_exists_outputs_info_to_stderr
         ActiveRecord::StatementInvalid.new("Can't create database 'dev'; database exists:")
       )
 
-      assert_raises(ActiveRecord::Tasks::DatabaseAlreadyExists) do
       ActiveRecord::Tasks::DatabaseTasks.create @configuration
     end
   end
-  end
 
   if current_adapter?(:MysqlAdapter)
     class MysqlDBCreateAsRootTest < ActiveRecord::TestCase

activerecord/test/cases/tasks/postgresql_rake_test.rb

@@ -60,10 +60,8 @@ def test_db_create_with_error_prints_message
       $stderr.expects(:puts).
         with("Couldn't create database for #{@configuration.inspect}")
 
-      assert_raises(Exception) do
       ActiveRecord::Tasks::DatabaseTasks.create @configuration
     end
-    end
 
     def test_create_when_database_exists_outputs_info_to_stderr
       $stderr.expects(:puts).with("my-app-db already exists").once
@@ -72,11 +70,9 @@ def test_create_when_database_exists_outputs_info_to_stderr
         ActiveRecord::StatementInvalid.new('database "my-app-db" already exists')
       )
 
-      assert_raises(ActiveRecord::Tasks::DatabaseAlreadyExists) do
       ActiveRecord::Tasks::DatabaseTasks.create @configuration
     end
   end
-  end
 
   class PostgreSQLDBDropTest < ActiveRecord::TestCase
     def setup

activerecord/test/cases/tasks/sqlite_rake_test.rb

@@ -28,10 +28,8 @@ def test_db_create_when_file_exists
 
       $stderr.expects(:puts).with("#{@database} already exists")
 
-      assert_raises(ActiveRecord::Tasks::DatabaseAlreadyExists) do
       ActiveRecord::Tasks::DatabaseTasks.create @configuration, '/rails/root'
     end
-    end
 
     def test_db_create_with_file_does_nothing
       File.stubs(:exist?).returns(true)
@@ -39,10 +37,8 @@ def test_db_create_with_file_does_nothing
 
       ActiveRecord::Base.expects(:establish_connection).never
 
-      assert_raises(ActiveRecord::Tasks::DatabaseAlreadyExists) do
       ActiveRecord::Tasks::DatabaseTasks.create @configuration, '/rails/root'
     end
-    end
 
     def test_db_create_establishes_a_connection
       ActiveRecord::Base.expects(:establish_connection).with(@configuration)
@@ -57,11 +53,9 @@ def test_db_create_with_error_prints_message
       $stderr.expects(:puts).
         with("Couldn't create database for #{@configuration.inspect}")
 
-      assert_raises(Exception) do
       ActiveRecord::Tasks::DatabaseTasks.create @configuration, '/rails/root'
     end
   end
-  end
 
   class SqliteDBDropTest < ActiveRecord::TestCase
     def setup