Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
5e86ee11
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
5e86ee11
编写于
8月 31, 2018
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Refactor `attributes_for_{create,update}` to avoid an extra allocation
Use `delete_if` instead of `reject` to avoid an extra allocation.
上级
56ca81a9
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
4 addition
and
4 deletion
+4
-4
activerecord/lib/active_record/attribute_methods.rb
activerecord/lib/active_record/attribute_methods.rb
+4
-2
activerecord/lib/active_record/persistence.rb
activerecord/lib/active_record/persistence.rb
+0
-2
未找到文件。
activerecord/lib/active_record/attribute_methods.rb
浏览文件 @
5e86ee11
...
@@ -459,7 +459,8 @@ def attributes_with_values(attribute_names)
...
@@ -459,7 +459,8 @@ def attributes_with_values(attribute_names)
# Filters the primary keys and readonly attributes from the attribute names.
# Filters the primary keys and readonly attributes from the attribute names.
def
attributes_for_update
(
attribute_names
)
def
attributes_for_update
(
attribute_names
)
attribute_names
.
reject
do
|
name
|
attribute_names
&=
self
.
class
.
column_names
attribute_names
.
delete_if
do
|
name
|
readonly_attribute?
(
name
)
readonly_attribute?
(
name
)
end
end
end
end
...
@@ -467,7 +468,8 @@ def attributes_for_update(attribute_names)
...
@@ -467,7 +468,8 @@ def attributes_for_update(attribute_names)
# Filters out the primary keys, from the attribute names, when the primary
# Filters out the primary keys, from the attribute names, when the primary
# key is to be generated (e.g. the id attribute has no value).
# key is to be generated (e.g. the id attribute has no value).
def
attributes_for_create
(
attribute_names
)
def
attributes_for_create
(
attribute_names
)
attribute_names
.
reject
do
|
name
|
attribute_names
&=
self
.
class
.
column_names
attribute_names
.
delete_if
do
|
name
|
pk_attribute?
(
name
)
&&
id
.
nil?
pk_attribute?
(
name
)
&&
id
.
nil?
end
end
end
end
...
...
activerecord/lib/active_record/persistence.rb
浏览文件 @
5e86ee11
...
@@ -718,7 +718,6 @@ def create_or_update(*args, &block)
...
@@ -718,7 +718,6 @@ def create_or_update(*args, &block)
# Updates the associated record with values matching those of the instance attributes.
# Updates the associated record with values matching those of the instance attributes.
# Returns the number of affected rows.
# Returns the number of affected rows.
def
_update_record
(
attribute_names
=
self
.
attribute_names
)
def
_update_record
(
attribute_names
=
self
.
attribute_names
)
attribute_names
&=
self
.
class
.
column_names
attribute_names
=
attributes_for_update
(
attribute_names
)
attribute_names
=
attributes_for_update
(
attribute_names
)
if
attribute_names
.
empty?
if
attribute_names
.
empty?
...
@@ -737,7 +736,6 @@ def _update_record(attribute_names = self.attribute_names)
...
@@ -737,7 +736,6 @@ def _update_record(attribute_names = self.attribute_names)
# Creates a record with values matching those of the instance attributes
# Creates a record with values matching those of the instance attributes
# and returns its id.
# and returns its id.
def
_create_record
(
attribute_names
=
self
.
attribute_names
)
def
_create_record
(
attribute_names
=
self
.
attribute_names
)
attribute_names
&=
self
.
class
.
column_names
attribute_names
=
attributes_for_create
(
attribute_names
)
attribute_names
=
attributes_for_create
(
attribute_names
)
new_id
=
self
.
class
.
_insert_record
(
new_id
=
self
.
class
.
_insert_record
(
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录