From 5d2789b11b89df8fed05c030cd63bbf07be41660 Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Thu, 16 Jan 2020 08:18:58 +0900 Subject: [PATCH] Avoid extra Array allocation for `build_tag_values` --- actionview/lib/action_view/helpers/tag_helper.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/actionview/lib/action_view/helpers/tag_helper.rb b/actionview/lib/action_view/helpers/tag_helper.rb index ad0df7fafb..b2a49d4329 100644 --- a/actionview/lib/action_view/helpers/tag_helper.rb +++ b/actionview/lib/action_view/helpers/tag_helper.rb @@ -340,16 +340,16 @@ def build_tag_values(*args) case tag_value when Hash tag_value.each do |key, val| - tag_values << key if val + tag_values << key.to_s if val && key.present? end when Array - tag_values << build_tag_values(*tag_value).presence + tag_values.concat build_tag_values(*tag_value) else tag_values << tag_value.to_s if tag_value.present? end end - tag_values.compact.flatten + tag_values end module_function :build_tag_values -- GitLab