From 52798fd479d4acbf823d093b03bdd1acf8e86b62 Mon Sep 17 00:00:00 2001
From: Yehuda Katz <wycats@gmail.com>
Date: Thu, 6 Aug 2009 19:50:22 -0300
Subject: [PATCH] rename ActionController::Http to ActionController::Metal at
 Josh's suggestion

---
 actionpack/examples/minimal.rb                            | 8 +++-----
 actionpack/examples/very_simple.rb                        | 2 +-
 actionpack/lib/action_controller.rb                       | 2 +-
 actionpack/lib/action_controller/abstract/base.rb         | 2 +-
 actionpack/lib/action_controller/base/base.rb             | 2 +-
 .../lib/action_controller/base/{http.rb => metal.rb}      | 6 +++---
 6 files changed, 10 insertions(+), 12 deletions(-)
 rename actionpack/lib/action_controller/base/{http.rb => metal.rb} (92%)

diff --git a/actionpack/examples/minimal.rb b/actionpack/examples/minimal.rb
index 9eb92cd8e7..7106149fa2 100644
--- a/actionpack/examples/minimal.rb
+++ b/actionpack/examples/minimal.rb
@@ -45,11 +45,9 @@ def index
 OK = [200, {}, []]
 MetalPostController = lambda { OK }
 
-if ActionController.const_defined?(:Http)
-  class HttpPostController < ActionController::Http
-    def index
-      self.response_body = ''
-    end
+class HttpPostController < ActionController::Metal
+  def index
+    self.response_body = ''
   end
 end
 
diff --git a/actionpack/examples/very_simple.rb b/actionpack/examples/very_simple.rb
index 995e40adb9..422c4c3298 100644
--- a/actionpack/examples/very_simple.rb
+++ b/actionpack/examples/very_simple.rb
@@ -3,7 +3,7 @@
 
 require "action_controller"
 
-class Kaigi < ActionController::Http
+class Kaigi < ActionController::Metal
   include AbstractController::Callbacks
   include ActionController::RackConvenience
   include ActionController::Renderer
diff --git a/actionpack/lib/action_controller.rb b/actionpack/lib/action_controller.rb
index 32572c93c0..b6bf620ffe 100644
--- a/actionpack/lib/action_controller.rb
+++ b/actionpack/lib/action_controller.rb
@@ -2,7 +2,7 @@ module ActionController
   autoload :Base,                 "action_controller/base/base"
   autoload :ConditionalGet,       "action_controller/base/conditional_get"
   autoload :HideActions,          "action_controller/base/hide_actions"
-  autoload :Http,                 "action_controller/base/http"
+  autoload :Metal,                "action_controller/base/metal"
   autoload :Layouts,              "action_controller/base/layouts"
   autoload :RackConvenience,      "action_controller/base/rack_convenience"
   autoload :Rails2Compatibility,  "action_controller/base/compatibility"
diff --git a/actionpack/lib/action_controller/abstract/base.rb b/actionpack/lib/action_controller/abstract/base.rb
index ca00e66349..b93e6ce634 100644
--- a/actionpack/lib/action_controller/abstract/base.rb
+++ b/actionpack/lib/action_controller/abstract/base.rb
@@ -30,7 +30,7 @@ def descendants
       # instance methods on that abstract class. Public instance methods of
       # a controller would normally be considered action methods, so we
       # are removing those methods on classes declared as abstract
-      # (ActionController::Http and ActionController::Base are defined
+      # (ActionController::Metal and ActionController::Base are defined
       # as abstract)
       def internal_methods
         controller = self
diff --git a/actionpack/lib/action_controller/base/base.rb b/actionpack/lib/action_controller/base/base.rb
index e541d24e31..9d9f735e27 100644
--- a/actionpack/lib/action_controller/base/base.rb
+++ b/actionpack/lib/action_controller/base/base.rb
@@ -1,5 +1,5 @@
 module ActionController
-  class Base < Http
+  class Base < Metal
     abstract!
 
     include AbstractController::Benchmarker
diff --git a/actionpack/lib/action_controller/base/http.rb b/actionpack/lib/action_controller/base/metal.rb
similarity index 92%
rename from actionpack/lib/action_controller/base/http.rb
rename to actionpack/lib/action_controller/base/metal.rb
index 3efd1b656f..e7d776b63e 100644
--- a/actionpack/lib/action_controller/base/http.rb
+++ b/actionpack/lib/action_controller/base/metal.rb
@@ -1,13 +1,13 @@
 require 'action_controller/abstract'
 
 module ActionController
-  # ActionController::Http provides a way to get a valid Rack application from a controller.
+  # ActionController::Metal provides a way to get a valid Rack application from a controller.
   #
   # In AbstractController, dispatching is triggered directly by calling #process on a new controller.
-  # ActionController::Http provides an #action method that returns a valid Rack application for a
+  # ActionController::Metal provides an #action method that returns a valid Rack application for a
   # given action. Other rack builders, such as Rack::Builder, Rack::URLMap, and the Rails router,
   # can dispatch directly to the action returned by FooController.action(:index).
-  class Http < AbstractController::Base
+  class Metal < AbstractController::Base
     abstract!
 
     # :api: public
-- 
GitLab