From 4d4d764ab688af4a0d213ab2d0dc7f9b811ab451 Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Tue, 14 Jul 2015 11:22:26 -0700 Subject: [PATCH] Rack implements `redirect?` so we don't need it Rack [already implements `redirect?` on the response object](https://github.com/rack/rack/blob/1569a985e17d9caaf94d0e97d95ef642c4ab14ba/lib/rack/response.rb#L141) so we don't need to implement our own. --- actionpack/lib/action_controller/test_case.rb | 3 --- actionpack/lib/action_dispatch/testing/test_response.rb | 3 --- 2 files changed, 6 deletions(-) diff --git a/actionpack/lib/action_controller/test_case.rb b/actionpack/lib/action_controller/test_case.rb index 098ef09c0e..f922e134f7 100644 --- a/actionpack/lib/action_controller/test_case.rb +++ b/actionpack/lib/action_controller/test_case.rb @@ -139,9 +139,6 @@ class LiveTestResponse < Live::Response # Was the URL not found? alias_method :missing?, :not_found? - # Were we redirected? - alias_method :redirect?, :redirection? - # Was there a server-side error? alias_method :error?, :server_error? end diff --git a/actionpack/lib/action_dispatch/testing/test_response.rb b/actionpack/lib/action_dispatch/testing/test_response.rb index a9b88ac5fd..6a31d6243f 100644 --- a/actionpack/lib/action_dispatch/testing/test_response.rb +++ b/actionpack/lib/action_dispatch/testing/test_response.rb @@ -16,9 +16,6 @@ def self.from_response(response) # Was the URL not found? alias_method :missing?, :not_found? - # Were we redirected? - alias_method :redirect?, :redirection? - # Was there a server-side error? alias_method :error?, :server_error? end -- GitLab