Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
49e69237
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
49e69237
编写于
1月 30, 2012
作者:
J
Jon Leighton
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #4732 from pwim/refactor-dynamic-match
Refactor dynamic match
上级
c99eb232
b08bf997
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
60 addition
and
28 deletion
+60
-28
activerecord/lib/active_record/dynamic_finder_match.rb
activerecord/lib/active_record/dynamic_finder_match.rb
+55
-27
activerecord/lib/active_record/dynamic_matchers.rb
activerecord/lib/active_record/dynamic_matchers.rb
+1
-1
activerecord/lib/active_record/dynamic_scope_match.rb
activerecord/lib/active_record/dynamic_scope_match.rb
+4
-0
未找到文件。
activerecord/lib/active_record/dynamic_finder_match.rb
浏览文件 @
49e69237
...
...
@@ -6,33 +6,23 @@ module ActiveRecord
#
class
DynamicFinderMatch
def
self
.
match
(
method
)
finder
=
:first
bang
=
false
instantiator
=
nil
case
method
.
to_s
when
/^find_(all_|last_)?by_([_a-zA-Z]\w*)$/
finder
=
:last
if
$1
==
'last_'
finder
=
:all
if
$1
==
'all_'
names
=
$2
when
/^find_by_([_a-zA-Z]\w*)\!$/
bang
=
true
names
=
$1
when
/^find_or_(initialize|create)_by_([_a-zA-Z]\w*)$/
instantiator
=
$1
==
'initialize'
?
:new
:
:create
names
=
$2
else
return
nil
method
=
method
.
to_s
klass
=
[
FindBy
,
FindByBang
,
FindOrInitializeCreateBy
].
find
do
|
klass
|
klass
.
matches?
(
method
)
end
klass
.
new
(
method
)
if
klass
end
new
(
finder
,
instantiator
,
bang
,
names
.
split
(
'_and_'
))
def
self
.
matches?
(
method
)
method
=~
self
::
METHOD_PATTERN
end
def
initialize
(
finder
,
instantiator
,
bang
,
attribute_names
)
@finder
=
finder
@instantiator
=
instantiator
@bang
=
bang
@attribute_names
=
attribute_names
def
initialize
(
method
)
@finder
=
:first
@instantiator
=
nil
match_data
=
method
.
match
(
self
.
class
::
METHOD_PATTERN
)
@attribute_names
=
match_data
[
-
1
].
split
(
"_and_"
)
initialize_from_match_data
(
match_data
)
end
attr_reader
:finder
,
:attribute_names
,
:instantiator
...
...
@@ -41,16 +31,54 @@ def finder?
@finder
&&
!
@instantiator
end
def
creator?
@finder
==
:first
&&
@instantiator
==
:create
end
def
instantiator?
@
finder
==
:first
&&
@
instantiator
@instantiator
end
def
creator?
@finder
==
:first
&&
@instantiator
==
:create
def
bang?
false
end
def
valid_arguments?
(
arguments
)
arguments
.
size
>=
@attribute_names
.
size
end
private
def
initialize_from_match_data
(
match_data
)
end
end
class
FindBy
<
DynamicFinderMatch
METHOD_PATTERN
=
/^find_(all_|last_)?by_([_a-zA-Z]\w*)$/
def
initialize_from_match_data
(
match_data
)
@finder
=
:last
if
match_data
[
1
]
==
'last_'
@finder
=
:all
if
match_data
[
1
]
==
'all_'
end
end
class
FindByBang
<
DynamicFinderMatch
METHOD_PATTERN
=
/^find_by_([_a-zA-Z]\w*)\!$/
def
bang?
@bang
true
end
end
class
FindOrInitializeCreateBy
<
DynamicFinderMatch
METHOD_PATTERN
=
/^find_or_(initialize|create)_by_([_a-zA-Z]\w*)$/
def
initialize_from_match_data
(
match_data
)
@instantiator
=
match_data
[
1
]
==
'initialize'
?
:new
:
:create
end
def
valid_arguments?
(
arguments
)
arguments
.
size
==
1
&&
arguments
.
first
.
is_a?
(
Hash
)
||
super
end
end
end
activerecord/lib/active_record/dynamic_matchers.rb
浏览文件 @
49e69237
...
...
@@ -25,7 +25,7 @@ def method_missing(method_id, *arguments, &block)
if
match
=
(
DynamicFinderMatch
.
match
(
method_id
)
||
DynamicScopeMatch
.
match
(
method_id
))
attribute_names
=
match
.
attribute_names
super
unless
all_attributes_exists?
(
attribute_names
)
if
!
(
match
.
is_a?
(
DynamicFinderMatch
)
&&
match
.
instantiator?
&&
arguments
.
first
.
is_a?
(
Hash
))
&&
arguments
.
size
<
attribute_names
.
size
unless
match
.
valid_arguments?
(
arguments
)
method_trace
=
"
#{
__FILE__
}
:
#{
__LINE__
}
:in `
#{
method_id
}
'"
backtrace
=
[
method_trace
]
+
caller
raise
ArgumentError
,
"wrong number of arguments (
#{
arguments
.
size
}
for
#{
attribute_names
.
size
}
)"
,
backtrace
...
...
activerecord/lib/active_record/dynamic_scope_match.rb
浏览文件 @
49e69237
...
...
@@ -19,5 +19,9 @@ def initialize(scope, attribute_names)
attr_reader
:scope
,
:attribute_names
alias
:scope?
:scope
def
valid_arguments?
(
arguments
)
arguments
.
size
>=
@attribute_names
.
size
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录