From 4943c7ed11ecb9c0ae2df369faecadead08f886b Mon Sep 17 00:00:00 2001 From: Yuji Yaginuma Date: Tue, 26 Dec 2017 08:23:33 +0900 Subject: [PATCH] Prevent to install gems when run test (#31564) `invoke_all` cause `bundle install`. This will install gems actually defined in `Gemfile`. To avoid this, stubbed `bundle_command`. Fixes #31557 --- railties/test/generators/app_generator_test.rb | 12 +++++++++--- railties/test/generators/shared_generator_tests.rb | 4 +++- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb index 793cce2999..fcb515c606 100644 --- a/railties/test/generators/app_generator_test.rb +++ b/railties/test/generators/app_generator_test.rb @@ -324,7 +324,9 @@ def test_active_storage_install end generator.stub :rails_command, command_check do - quietly { generator.invoke_all } + generator.stub :bundle_command, nil do + quietly { generator.invoke_all } + end end end @@ -762,7 +764,9 @@ def test_webpack_option end generator([destination_root], webpack: "webpack").stub(:rails_command, command_check) do - quietly { generator.invoke_all } + generator.stub :bundle_command, nil do + quietly { generator.invoke_all } + end end assert_gem "webpacker" @@ -783,7 +787,9 @@ def test_webpack_option_with_js_framework end generator([destination_root], webpack: "react").stub(:rails_command, command_check) do - quietly { generator.invoke_all } + generator.stub :bundle_command, nil do + quietly { generator.invoke_all } + end end end diff --git a/railties/test/generators/shared_generator_tests.rb b/railties/test/generators/shared_generator_tests.rb index 7a746f5b62..29528825b8 100644 --- a/railties/test/generators/shared_generator_tests.rb +++ b/railties/test/generators/shared_generator_tests.rb @@ -92,7 +92,9 @@ def test_template_is_executed_when_supplied_an_https_path end generator([destination_root], template: path).stub(:open, check_open, template) do - quietly { assert_match(/It works!/, capture(:stdout) { generator.invoke_all }) } + generator.stub :bundle_command, nil do + quietly { assert_match(/It works!/, capture(:stdout) { generator.invoke_all }) } + end end end -- GitLab