From 46796e74cfbb8f07b9bfc6d28dcf9867f4c664c0 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Mon, 3 Apr 2006 22:39:36 +0000 Subject: [PATCH] Fixed that rails --version should have the return code of 0 (success) (closes #4560) [blair@orcaware.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- railties/CHANGELOG | 2 ++ railties/bin/rails | 5 ++++- railties/lib/dispatcher.rb | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/railties/CHANGELOG b/railties/CHANGELOG index 0633435e10..963226000d 100644 --- a/railties/CHANGELOG +++ b/railties/CHANGELOG @@ -1,5 +1,7 @@ *SVN* +* Fixed that rails --version should have the return code of 0 (success) #4560 [blair@orcaware.com] + * Install alias so Rails::InfoController is accessible at /rails_info. Closes #4546. [Nicholas Seckar] * Fixed that spawner should daemonize if running in repeat mode [DHH] diff --git a/railties/bin/rails b/railties/bin/rails index d83f5b8b8e..ae0cc8adca 100755 --- a/railties/bin/rails +++ b/railties/bin/rails @@ -2,7 +2,10 @@ require File.dirname(__FILE__) + '/../lib/ruby_version_check' Signal.trap("INT") { puts; exit } require File.dirname(__FILE__) + '/../lib/rails/version' -abort "Rails #{Rails::VERSION::STRING}" if %w(--version -v).include? ARGV.first +if %w(--version -v).include? ARGV.first + puts "Rails #{Rails::VERSION::STRING}" + exit(0) +end freeze = ARGV.any? { |option| %w(--freeze -f).include?(option) } app_path = ARGV.first diff --git a/railties/lib/dispatcher.rb b/railties/lib/dispatcher.rb index d5e0345dd5..be194cd2b0 100644 --- a/railties/lib/dispatcher.rb +++ b/railties/lib/dispatcher.rb @@ -91,7 +91,7 @@ def failsafe_response(output, status, exception = nil) begin output.write "Status: #{status}\r\n" output.write "Content-Type: text/plain\r\n\r\n" - output.write exception.to_s + "\r\n" + exception.backtrace.join("\r\n") if exception + output.write(exception.to_s + "\r\n" + exception.backtrace.join("\r\n")) if exception rescue Object end end -- GitLab