From 3747f896a1b727d67e6022001007e5f58b24a267 Mon Sep 17 00:00:00 2001
From: Emilio Tagua <miloops@gmail.com>
Date: Mon, 5 Oct 2009 14:39:20 -0300
Subject: [PATCH] Moved relation's test to relation_test.

---
 activerecord/lib/active_record/base.rb         |  3 +--
 activerecord/test/cases/method_scoping_test.rb |  4 ++--
 activerecord/test/cases/relations_test.rb      | 11 +++++++++++
 arel                                           |  2 +-
 4 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb
index 1c12189e15..2fd3384877 100755
--- a/activerecord/lib/active_record/base.rb
+++ b/activerecord/lib/active_record/base.rb
@@ -667,7 +667,7 @@ def all(*args)
         options = args.extract_options!
 
 
-        if options.empty? #&& !scoped?(:find)
+        if options.empty? && !scoped?(:find)
           relation = arel_table
         else
           include_associations = merge_includes(scope(:find, :include), options[:include])
@@ -1751,7 +1751,6 @@ def construct_finder_arel(options = {}, scope = scope(:find))
           relation = relation.readonly if options[:readonly]
 
           relation
-
         end
 
         def construct_finder_sql(options, scope = scope(:find))
diff --git a/activerecord/test/cases/method_scoping_test.rb b/activerecord/test/cases/method_scoping_test.rb
index 6dec474f7d..eb4ce0e774 100644
--- a/activerecord/test/cases/method_scoping_test.rb
+++ b/activerecord/test/cases/method_scoping_test.rb
@@ -593,12 +593,12 @@ def test_default_scope
   end
 
   def test_default_scope_with_conditions_string
-    assert_equal Developer.find_all_by_name('David').map(&:id).sort, DeveloperCalledDavid.all.to_a.map(&:id).sort
+    assert_equal Developer.find_all_by_name('David').map(&:id).sort, DeveloperCalledDavid.find(:all).map(&:id).sort
     assert_equal nil, DeveloperCalledDavid.create!.name
   end
 
   def test_default_scope_with_conditions_hash
-    assert_equal Developer.find_all_by_name('Jamis').map(&:id).sort, DeveloperCalledJamis.all.to_a.map(&:id).sort
+    assert_equal Developer.find_all_by_name('Jamis').map(&:id).sort, DeveloperCalledJamis.find(:all).map(&:id).sort
     assert_equal 'Jamis', DeveloperCalledJamis.create!.name
   end
 
diff --git a/activerecord/test/cases/relations_test.rb b/activerecord/test/cases/relations_test.rb
index 6fb505ca36..17c228616b 100644
--- a/activerecord/test/cases/relations_test.rb
+++ b/activerecord/test/cases/relations_test.rb
@@ -114,5 +114,16 @@ def test_find_with_included_associations
       posts.first.author
     end
   end
+
+    def test_default_scope_with_conditions_string
+    assert_equal Developer.find_all_by_name('David').map(&:id).sort, DeveloperCalledDavid.all.to_a.map(&:id).sort
+    assert_equal nil, DeveloperCalledDavid.create!.name
+  end
+
+  def test_default_scope_with_conditions_hash
+    assert_equal Developer.find_all_by_name('Jamis').map(&:id).sort, DeveloperCalledJamis.all.to_a.map(&:id).sort
+    assert_equal 'Jamis', DeveloperCalledJamis.create!.name
+  end
+
 end
 
diff --git a/arel b/arel
index 755a7ced2f..8852db7087 160000
--- a/arel
+++ b/arel
@@ -1 +1 @@
-Subproject commit 755a7ced2f98b0bb246089c80cdfa04cd918fa89
+Subproject commit 8852db7087a8f4f98e5fd26fa33bac14a5400979
-- 
GitLab