diff --git a/activerecord/test/cases/query_cache_test.rb b/activerecord/test/cases/query_cache_test.rb index 109e4bffcc3ced5874c370cbd7692832039908aa..1229741cebe1fb88f7dadcef9d321e5239492037 100644 --- a/activerecord/test/cases/query_cache_test.rb +++ b/activerecord/test/cases/query_cache_test.rb @@ -651,6 +651,8 @@ def test_insert end def test_insert_all + skip unless supports_insert_on_duplicate_skip? + assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do Task.cache { Task.insert({ starting: Time.now }) } end @@ -658,7 +660,9 @@ def test_insert_all assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do Task.cache { Task.insert_all([{ starting: Time.now }]) } end + end + def test_insert_all_bang assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do Task.cache { Task.insert!({ starting: Time.now }) } end @@ -666,6 +670,10 @@ def test_insert_all assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do Task.cache { Task.insert_all!([{ starting: Time.now }]) } end + end + + def test_upsert_all + skip unless supports_insert_on_duplicate_update? assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do Task.cache { Task.upsert({ starting: Time.now }) }