From 2d749cbea932c203ecb7532fd24b8e34cb1387da Mon Sep 17 00:00:00 2001 From: Alberto Almagro Date: Sat, 10 Nov 2018 21:49:11 +0100 Subject: [PATCH] Prefer assert_not instead of refute [ci skip] As mentioned in the contributing to Ruby on Rails guides, we should prefer `assert_not` instead of `refute`. And the best place to start giving example are our bug report templates.. See: https://github.com/rails/rails/blame/master/guides/source/contributing_to_ruby_on_rails.md#L256 --- guides/bug_report_templates/generic_gem.rb | 2 +- guides/bug_report_templates/generic_master.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guides/bug_report_templates/generic_gem.rb b/guides/bug_report_templates/generic_gem.rb index 3fd54437f7..3ef69e6775 100644 --- a/guides/bug_report_templates/generic_gem.rb +++ b/guides/bug_report_templates/generic_gem.rb @@ -18,6 +18,6 @@ class BugTest < Minitest::Test def test_stuff assert "zomg".present? - refute "".present? + assert_not "".present? end end diff --git a/guides/bug_report_templates/generic_master.rb b/guides/bug_report_templates/generic_master.rb index ec65fee292..63b1ef3287 100644 --- a/guides/bug_report_templates/generic_master.rb +++ b/guides/bug_report_templates/generic_master.rb @@ -17,6 +17,6 @@ class BugTest < Minitest::Test def test_stuff assert "zomg".present? - refute "".present? + assert_not "".present? end end -- GitLab