From 24affdc88c4a4af03ce1ec5b23c3def18b90effe Mon Sep 17 00:00:00 2001
From: Joshua Peek <josh@joshpeek.com>
Date: Sat, 2 May 2009 15:37:29 -0500
Subject: [PATCH] Deprecate Controller.process interface

---
 actionpack/lib/action_controller/base/base.rb |  1 +
 actionpack/test/controller/filters_test.rb    |  2 +-
 actionpack/test/controller/helper_test.rb     | 20 ++++++++++---------
 3 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/actionpack/lib/action_controller/base/base.rb b/actionpack/lib/action_controller/base/base.rb
index eb65f59ddd..60567454b1 100644
--- a/actionpack/lib/action_controller/base/base.rb
+++ b/actionpack/lib/action_controller/base/base.rb
@@ -376,6 +376,7 @@ def call(env)
 
       # Factory for the standard create, process loop where the controller is discarded after processing.
       def process(request, response) #:nodoc:
+        ActiveSupport::Deprecation.warn("Controller.process has been deprecated. Use Controller.call instead", caller)
         new.process(request, response)
       end
 
diff --git a/actionpack/test/controller/filters_test.rb b/actionpack/test/controller/filters_test.rb
index 9e74538310..5876f55420 100644
--- a/actionpack/test/controller/filters_test.rb
+++ b/actionpack/test/controller/filters_test.rb
@@ -603,7 +603,7 @@ def test_dynamic_dispatch
     %w(foo bar baz).each do |action|
       request = ActionController::TestRequest.new
       request.query_parameters[:choose] = action
-      response = DynamicDispatchController.process(request, ActionController::TestResponse.new)
+      response = Rack::MockResponse.new(*DynamicDispatchController.call(request.env))
       assert_equal action, response.body
     end
   end
diff --git a/actionpack/test/controller/helper_test.rb b/actionpack/test/controller/helper_test.rb
index 58addc123d..e72bce1791 100644
--- a/actionpack/test/controller/helper_test.rb
+++ b/actionpack/test/controller/helper_test.rb
@@ -102,19 +102,19 @@ def test_helper_attr
   end
 
   def test_helper_for_nested_controller
-    request  = ActionController::TestRequest.new
-    response = ActionController::TestResponse.new
+    request = ActionController::TestRequest.new
     request.action = 'render_hello_world'
 
-    assert_equal 'hello: Iz guuut!', Fun::GamesController.process(request, response).body
+    response = Rack::MockResponse.new(*Fun::GamesController.call(request.env))
+    assert_equal 'hello: Iz guuut!', response.body
   end
 
   def test_helper_for_acronym_controller
-    request  = ActionController::TestRequest.new
-    response = ActionController::TestResponse.new
+    request = ActionController::TestRequest.new
     request.action = 'test'
 
-    assert_equal 'test: baz', Fun::PdfController.process(request, response).body
+    response = Rack::MockResponse.new(*Fun::PdfController.call(request.env))
+    assert_equal 'test: baz', response.body
   end
 
   def test_all_helpers
@@ -211,14 +211,16 @@ def setup
   end
 
   def test_helper_in_a
-    assert_raise(ActionView::TemplateError) { A.process(@request, @response) }
+    assert_raise(ActionView::TemplateError) { A.call(@request.env) }
   end
 
   def test_helper_in_b
-    assert_equal 'B', B.process(@request, @response).body
+    response = Rack::MockResponse.new(*B.call(@request.env))
+    assert_equal 'B', response.body
   end
 
   def test_helper_in_c
-    assert_equal 'C', C.process(@request, @response).body
+    response = Rack::MockResponse.new(*C.call(@request.env))
+    assert_equal 'C', response.body
   end
 end
-- 
GitLab