From 01893f43f68f3cba24751022131d51702d188979 Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Tue, 12 Oct 2010 11:55:52 -0700 Subject: [PATCH] reducing comparisons in when statements --- .../connection_adapters/abstract/quoting.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb b/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb index 603e4de564..b28eb3f758 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb @@ -22,13 +22,13 @@ def quote(value, column = nil) "'#{quote_string(value)}'" # ' (for ruby-mode) end - when NilClass then "NULL" - when TrueClass then (column && column.type == :integer ? '1' : quoted_true) - when FalseClass then (column && column.type == :integer ? '0' : quoted_false) - when Float, Fixnum, Bignum then value.to_s + when nil then "NULL" + when true then (column && column.type == :integer ? '1' : quoted_true) + when false then (column && column.type == :integer ? '0' : quoted_false) # BigDecimals need to be put in a non-normalized form and quoted. - when BigDecimal then value.to_s('F') - when Date, Time, DateTime then "'#{quoted_date(value)}'" + when BigDecimal then value.to_s('F') + when Numeric then value.to_s + when Date, Time then "'#{quoted_date(value)}'" else "'#{quote_string(value.to_s)}'" end -- GitLab