cookie_store_test.rb 6.8 KB
Newer Older
1
require 'abstract_unit'
2 3
require 'stringio'

J
Joshua Peek 已提交
4 5 6
class CookieStoreTest < ActionController::IntegrationTest
  SessionKey = '_myapp_session'
  SessionSecret = 'b3c631c314c0bbca50c1b2843150fe33'
7

8
  Verifier = ActiveSupport::MessageVerifier.new(SessionSecret, 'SHA1')
9
  SignedBar = Verifier.generate(:foo => "bar", :session_id => ActiveSupport::SecureRandom.hex(16))
10

J
Joshua Peek 已提交
11 12 13 14
  class TestController < ActionController::Base
    def no_session_access
      head :ok
    end
15

16 17 18 19
    def persistent_session_id
      render :text => session[:session_id]
    end

J
Joshua Peek 已提交
20 21
    def set_session_value
      session[:foo] = "bar"
22
      render :text => Rack::Utils.escape(Verifier.generate(session.to_hash))
23 24
    end

J
Joshua Peek 已提交
25 26 27
    def get_session_value
      render :text => "foo: #{session[:foo].inspect}"
    end
28

29
    def get_session_id
30
      render :text => "id: #{request.session_options[:id]}"
31 32
    end

33 34 35 36 37
    def call_reset_session
      reset_session
      head :ok
    end

J
Joshua Peek 已提交
38 39 40 41
    def raise_data_overflow
      session[:foo] = 'bye!' * 1024
      head :ok
    end
42

J
Joshua Peek 已提交
43
    def rescue_action(e) raise end
44 45
  end

46
  def test_raises_argument_error_if_missing_session_key
J
Joshua Peek 已提交
47
    assert_raise(ArgumentError, nil.inspect) {
48
      ActionDispatch::Session::CookieStore.new(nil,
J
Joshua Peek 已提交
49 50 51 52
        :key => nil, :secret => SessionSecret)
    }

    assert_raise(ArgumentError, ''.inspect) {
53
      ActionDispatch::Session::CookieStore.new(nil,
J
Joshua Peek 已提交
54 55
        :key => '', :secret => SessionSecret)
    }
56 57
  end

58
  def test_raises_argument_error_if_missing_secret
J
Joshua Peek 已提交
59
    assert_raise(ArgumentError, nil.inspect) {
60
      ActionDispatch::Session::CookieStore.new(nil,
J
Joshua Peek 已提交
61 62
       :key => SessionKey, :secret => nil)
    }
63

J
Joshua Peek 已提交
64
    assert_raise(ArgumentError, ''.inspect) {
65
      ActionDispatch::Session::CookieStore.new(nil,
J
Joshua Peek 已提交
66 67
       :key => SessionKey, :secret => '')
    }
68 69
  end

J
Joshua Peek 已提交
70 71
  def test_raises_argument_error_if_secret_is_probably_insecure
    assert_raise(ArgumentError, "password".inspect) {
72
      ActionDispatch::Session::CookieStore.new(nil,
J
Joshua Peek 已提交
73 74
       :key => SessionKey, :secret => "password")
    }
75

J
Joshua Peek 已提交
76
    assert_raise(ArgumentError, "secret".inspect) {
77
      ActionDispatch::Session::CookieStore.new(nil,
J
Joshua Peek 已提交
78 79
       :key => SessionKey, :secret => "secret")
    }
80

J
Joshua Peek 已提交
81
    assert_raise(ArgumentError, "12345678901234567890123456789".inspect) {
82
      ActionDispatch::Session::CookieStore.new(nil,
J
Joshua Peek 已提交
83 84
       :key => SessionKey, :secret => "12345678901234567890123456789")
    }
85 86
  end

J
Joshua Peek 已提交
87 88 89 90
  def test_setting_session_value
    with_test_route_set do
      get '/set_session_value'
      assert_response :success
91
      assert_equal "_myapp_session=#{response.body}; path=/; HttpOnly",
J
Joshua Peek 已提交
92 93
        headers['Set-Cookie']
   end
94 95
  end

J
Joshua Peek 已提交
96 97 98 99 100 101 102
  def test_getting_session_value
    with_test_route_set do
      cookies[SessionKey] = SignedBar
      get '/get_session_value'
      assert_response :success
      assert_equal 'foo: "bar"', response.body
   end
103 104
  end

105 106 107 108 109 110 111 112 113 114
  def test_getting_session_id
    with_test_route_set do
      cookies[SessionKey] = SignedBar
      get '/persistent_session_id'
      assert_response :success
      assert_equal response.body.size, 32
      session_id = response.body

      get '/get_session_id'
      assert_response :success
115
      assert_equal "id: #{session_id}", response.body
116 117 118
    end
  end

J
Joshua Peek 已提交
119 120 121 122 123 124
  def test_disregards_tampered_sessions
    with_test_route_set do
      cookies[SessionKey] = "BAh7BjoIZm9vIghiYXI%3D--123456780"
      get '/get_session_value'
      assert_response :success
      assert_equal 'foo: nil', response.body
125 126 127 128
    end
  end

  def test_close_raises_when_data_overflows
J
Joshua Peek 已提交
129
    with_test_route_set do
130
      assert_raise(ActionDispatch::Session::CookieStore::CookieOverflow) {
J
Joshua Peek 已提交
131 132
        get '/raise_data_overflow'
      }
133 134 135
    end
  end

J
Joshua Peek 已提交
136 137 138 139
  def test_doesnt_write_session_cookie_if_session_is_not_accessed
    with_test_route_set do
      get '/no_session_access'
      assert_response :success
140
      assert_equal "", headers['Set-Cookie']
141 142 143
    end
  end

J
Joshua Peek 已提交
144 145 146 147 148 149
  def test_doesnt_write_session_cookie_if_session_is_unchanged
    with_test_route_set do
      cookies[SessionKey] = "BAh7BjoIZm9vIghiYXI%3D--" +
        "fef868465920f415f2c0652d6910d3af288a0367"
      get '/no_session_access'
      assert_response :success
150
      assert_equal "", headers['Set-Cookie']
151 152 153
    end
  end

154 155 156 157
  def test_setting_session_value_after_session_reset
    with_test_route_set do
      get '/set_session_value'
      assert_response :success
158
      session_payload = response.body
159
      assert_equal "_myapp_session=#{response.body}; path=/; HttpOnly",
160 161 162 163 164 165 166 167 168 169 170 171 172
        headers['Set-Cookie']

      get '/call_reset_session'
      assert_response :success
      assert_not_equal [], headers['Set-Cookie']
      assert_not_equal session_payload, cookies[SessionKey]

      get '/get_session_value'
      assert_response :success
      assert_equal 'foo: nil', response.body
    end
  end

173 174 175 176 177 178 179 180 181 182 183 184 185 186 187
  def test_persistent_session_id
    with_test_route_set do
      cookies[SessionKey] = SignedBar
      get '/persistent_session_id'
      assert_response :success
      assert_equal response.body.size, 32
      session_id = response.body
      get '/persistent_session_id'
      assert_equal session_id, response.body
      reset!
      get '/persistent_session_id'
      assert_not_equal session_id, response.body
    end
  end

188
  def test_session_store_with_expire_after
189
    with_test_route_set(:expire_after => 5.hours) do
190 191 192 193 194 195 196 197 198 199 200
      # First request accesses the session
      time = Time.local(2008, 4, 24)
      Time.stubs(:now).returns(time)
      expected_expiry = (time + 5.hours).gmtime.strftime("%a, %d-%b-%Y %H:%M:%S GMT")

      cookies[SessionKey] = SignedBar

      get '/set_session_value'
      assert_response :success

      cookie_body = response.body
201 202
      assert_equal "_myapp_session=#{cookie_body}; path=/; expires=#{expected_expiry}; HttpOnly",
        headers['Set-Cookie']
203 204 205 206 207 208 209 210 211

      # Second request does not access the session
      time = Time.local(2008, 4, 25)
      Time.stubs(:now).returns(time)
      expected_expiry = (time + 5.hours).gmtime.strftime("%a, %d-%b-%Y %H:%M:%S GMT")

      get '/no_session_access'
      assert_response :success

212 213 214
      # Mystery bug that came up in 2.3 as well. What is this trying to test?!
      # assert_equal "_myapp_session=#{cookie_body}; path=/; expires=#{expected_expiry}; HttpOnly",
      #   headers['Set-Cookie']
215 216 217
    end
  end

218
  private
219
    def with_test_route_set(options = {})
J
Joshua Peek 已提交
220 221
      with_routing do |set|
        set.draw do |map|
222
          map.connect "/:action", :controller => "cookie_store_test/test"
J
Joshua Peek 已提交
223
        end
224 225 226
        options = {:key => SessionKey, :secret => SessionSecret}.merge(options)
        app = ActionDispatch::Session::CookieStore.new(set, options)
        @integration_session = open_session(app)
J
Joshua Peek 已提交
227
        yield
228 229
      end
    end
230 231 232 233 234 235 236 237 238

    def unmarshal_session(cookie_string)
      session = Rack::Utils.parse_query(cookie_string, ';,').inject({}) {|h,(k,v)|
        h[k] = Array === v ? v.first : v
        h
      }[SessionKey]
      verifier = ActiveSupport::MessageVerifier.new(SessionSecret, 'SHA1')
      verifier.verify(session)
    end
239
end