From 8ec5276d30dac59ced0ca7e35e07e20644ee2188 Mon Sep 17 00:00:00 2001
From: Ryan Dahl <ry@tinyclouds.org>
Date: Sat, 8 Jun 2019 18:11:47 -0400
Subject: [PATCH] Add asserts checking that async ops return null (#2463)

---
 js/dispatch.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/js/dispatch.ts b/js/dispatch.ts
index 64bdfda1..0c6e7070 100644
--- a/js/dispatch.ts
+++ b/js/dispatch.ts
@@ -91,7 +91,7 @@ export function sendAsync(
     data,
     false
   );
-  util.assert(response == null);
+  util.assert(response == null); // null indicates async.
   const promise = util.createResolvable<msg.Base>();
   promiseTable.set(cmdId, promise);
   return promise;
@@ -106,10 +106,11 @@ export function sendSync(
 ): null | msg.Base {
   const [cmdId, response] = sendInternal(builder, innerType, inner, data, true);
   util.assert(cmdId >= 0);
-  if (response == null || response.length === 0) {
+  util.assert(response != null); // null indicates async.
+  if (response!.length === 0) {
     return null;
   } else {
-    const bb = new flatbuffers.ByteBuffer(response);
+    const bb = new flatbuffers.ByteBuffer(response!);
     const baseRes = msg.Base.getRootAsBase(bb);
     errors.maybeThrowError(baseRes);
     return baseRes;
-- 
GitLab