From e8a1c082daf7b79ec36aa6dfe3a079ba222f3e2b Mon Sep 17 00:00:00 2001 From: jp9000 Date: Thu, 11 Feb 2021 22:34:55 -0800 Subject: [PATCH] Revert "UI: Add ability for stingers to use filters" This reverts commit 36ab7b97cff3bad9f3056b2f3cb1fa6a7158f79b. The fact that a transition is a composition of two scenes was not factored into the merging of this PR. Thus, it would apply to the underlying scenes when transitioning, making the effectiveness of this feature cause inconsistent rendering of the underlying scenes when transitions are activated versus when they're not. --- UI/window-basic-main-transitions.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/UI/window-basic-main-transitions.cpp b/UI/window-basic-main-transitions.cpp index a4ff34e8d..8b491a8cf 100644 --- a/UI/window-basic-main-transitions.cpp +++ b/UI/window-basic-main-transitions.cpp @@ -657,7 +657,6 @@ void OBSBasic::on_transitionProps_clicked() return; auto properties = [&]() { CreatePropertiesWindow(source); }; - auto filters = [&]() { CreateFiltersWindow(source); }; QMenu menu(this); @@ -675,13 +674,6 @@ void OBSBasic::on_transitionProps_clicked() connect(action, &QAction::triggered, properties); menu.addAction(action); - if (strcmp(obs_source_get_unversioned_id(source), - "obs_stinger_transition") == 0) { - action = new QAction(QTStr("Filters"), &menu); - connect(action, &QAction::triggered, filters); - menu.addAction(action); - } - menu.exec(QCursor::pos()); } -- GitLab