From 580f38a73307f72fea562fd66733f537a717cb23 Mon Sep 17 00:00:00 2001 From: jp9000 Date: Sat, 17 Dec 2016 15:32:19 -0800 Subject: [PATCH] UI: Remove deleteLater view from filter window layout In the filters dialog, when the properties are being updated due to filters being added/removed/switched, using deleteLater on the previous view would cause it to linger in the view until the deleteLater is processed by the Qt queue, displaying two views instead of one. Additionally because of that, this would also cause the display in the filters dialog to resize as well, causing the reorder mutex hard lock which was fixed by the parent commit. Closes jp9000/obs-studio#714 --- UI/window-basic-filters.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/UI/window-basic-filters.cpp b/UI/window-basic-filters.cpp index f3bb847f6..f3d53e8f3 100644 --- a/UI/window-basic-filters.cpp +++ b/UI/window-basic-filters.cpp @@ -147,6 +147,7 @@ inline OBSSource OBSBasicFilters::GetFilter(int row, bool async) void OBSBasicFilters::UpdatePropertiesView(int row, bool async) { if (view) { + ui->rightLayout->removeWidget(view); view->deleteLater(); view = nullptr; } -- GitLab