From b132fde01de8352b43fb8f68f308c232eea91212 Mon Sep 17 00:00:00 2001
From: hedaoyuan <hedaoyuan@github.com>
Date: Fri, 23 Dec 2016 15:20:12 +0800
Subject: [PATCH] follow some comments with issue 973

---
 paddle/function/CMakeLists.txt                         | 10 +++++-----
 .../{cross_map_normal_op.cpp => CrossMapNormalOp.cpp}  |  2 +-
 .../{cross_map_normal_op.h => CrossMapNormalOp.h}      |  0
 ...oss_map_normal_op_gpu.cu => CrossMapNormalOpGpu.cu} |  2 +-
 ...map_normal_op_test.cpp => CrossMapNormalOpTest.cpp} |  4 ++++
 paddle/function/FunctionTest.h                         |  5 -----
 6 files changed, 11 insertions(+), 12 deletions(-)
 rename paddle/function/{cross_map_normal_op.cpp => CrossMapNormalOp.cpp} (99%)
 rename paddle/function/{cross_map_normal_op.h => CrossMapNormalOp.h} (100%)
 rename paddle/function/{cross_map_normal_op_gpu.cu => CrossMapNormalOpGpu.cu} (99%)
 rename paddle/function/{cross_map_normal_op_test.cpp => CrossMapNormalOpTest.cpp} (98%)

diff --git a/paddle/function/CMakeLists.txt b/paddle/function/CMakeLists.txt
index 0697842bbe..4660324423 100644
--- a/paddle/function/CMakeLists.txt
+++ b/paddle/function/CMakeLists.txt
@@ -1,11 +1,11 @@
-file(GLOB h_files . *_op.h)
-file(GLOB cpp_files . *_op.cpp)
+file(GLOB h_files . *Op.h)
+file(GLOB cpp_files . *Op.cpp)
 
 list(APPEND h_files Function.h)
 list(APPEND cpp_files Function.cpp)
 
 if(WITH_GPU)
-    file(GLOB cu_files . *_op_gpu.cu)
+    file(GLOB cu_files . *OpGpu.cu)
     cuda_compile(cu_objs ${cu_files})
 endif()
 
@@ -15,9 +15,9 @@ add_library(paddle_test_main STATIC TestMain.cpp)
 
 if(WITH_GPU)
     # TODO:
-    # file(GLOB test_files . *_op_test.cpp)
+    # file(GLOB test_files . *OpTest.cpp)
     # add_executable(${test_bin} EXCLUDE_FROM_ALL ${test_files})
-    add_simple_unittest(cross_map_normal_op_test)
+    add_simple_unittest(CrossMapNormalOpTest)
 endif()
 
 add_style_check_target(paddle_function ${h_files})
diff --git a/paddle/function/cross_map_normal_op.cpp b/paddle/function/CrossMapNormalOp.cpp
similarity index 99%
rename from paddle/function/cross_map_normal_op.cpp
rename to paddle/function/CrossMapNormalOp.cpp
index a9c7693830..f13eb78d27 100644
--- a/paddle/function/cross_map_normal_op.cpp
+++ b/paddle/function/CrossMapNormalOp.cpp
@@ -12,7 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. */
 
-#include "cross_map_normal_op.h"
+#include "CrossMapNormalOp.h"
 #include "paddle/math/Vector.h"
 
 namespace paddle {
diff --git a/paddle/function/cross_map_normal_op.h b/paddle/function/CrossMapNormalOp.h
similarity index 100%
rename from paddle/function/cross_map_normal_op.h
rename to paddle/function/CrossMapNormalOp.h
diff --git a/paddle/function/cross_map_normal_op_gpu.cu b/paddle/function/CrossMapNormalOpGpu.cu
similarity index 99%
rename from paddle/function/cross_map_normal_op_gpu.cu
rename to paddle/function/CrossMapNormalOpGpu.cu
index aae4f461b6..b33dd10834 100644
--- a/paddle/function/cross_map_normal_op_gpu.cu
+++ b/paddle/function/CrossMapNormalOpGpu.cu
@@ -13,7 +13,7 @@ See the License for the specific language governing permissions and
 limitations under the License. */
 
 #include "hl_base.h"
-#include "cross_map_normal_op.h"
+#include "CrossMapNormalOp.h"
 
 namespace paddle {
 
diff --git a/paddle/function/cross_map_normal_op_test.cpp b/paddle/function/CrossMapNormalOpTest.cpp
similarity index 98%
rename from paddle/function/cross_map_normal_op_test.cpp
rename to paddle/function/CrossMapNormalOpTest.cpp
index 22692691bd..d65d9310af 100644
--- a/paddle/function/cross_map_normal_op_test.cpp
+++ b/paddle/function/CrossMapNormalOpTest.cpp
@@ -15,6 +15,8 @@ limitations under the License. */
 #include <gtest/gtest.h>
 #include "FunctionTest.h"
 
+namespace paddle {
+
 TEST(CrossMapNormal, real) {
   for (size_t numSamples : {5, 32}) {
     for (size_t channels : {1, 5, 32}) {
@@ -69,3 +71,5 @@ TEST(CrossMapNormalGrad, real) {
     }
   }
 }
+
+}  // namespace paddle
diff --git a/paddle/function/FunctionTest.h b/paddle/function/FunctionTest.h
index a8c5e412bd..a602bde57e 100644
--- a/paddle/function/FunctionTest.h
+++ b/paddle/function/FunctionTest.h
@@ -95,8 +95,3 @@ protected:
 };
 
 }  // namespace paddle
-
-using paddle::FunctionCompare;
-using paddle::FuncConfig;
-using paddle::Dims;
-using paddle::Tensor;
-- 
GitLab