From c7fc5c19ff2827d238ae25dcc33b94b4ae583fa2 Mon Sep 17 00:00:00 2001 From: Peter Pan Date: Thu, 10 Sep 2020 16:51:57 +0800 Subject: [PATCH] fix: histogram cannot be rendered properly when data only has step 0 (#807) --- frontend/packages/core/builder/mock.js | 5 ++++- frontend/packages/core/package.json | 1 + frontend/packages/core/src/components/StackChart.tsx | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/frontend/packages/core/builder/mock.js b/frontend/packages/core/builder/mock.js index 39e5c0ef..9a5ef38a 100644 --- a/frontend/packages/core/builder/mock.js +++ b/frontend/packages/core/builder/mock.js @@ -1,8 +1,11 @@ /* eslint-disable @typescript-eslint/no-var-requires */ const {middleware} = require('@visualdl/mock'); +const {createProxyMiddleware} = require('http-proxy-middleware'); module.exports = { - middleware, + middleware: process.env.MOCK + ? () => createProxyMiddleware({target: process.env.MOCK, changeOrigin: true}) + : middleware, pathname: '/api' }; diff --git a/frontend/packages/core/package.json b/frontend/packages/core/package.json index 14b137da..31c183a3 100644 --- a/frontend/packages/core/package.json +++ b/frontend/packages/core/package.json @@ -96,6 +96,7 @@ "enhanced-resolve": "4.3.0", "express": "4.17.1", "fs-extra": "9.0.1", + "http-proxy-middleware": "1.0.5", "jest": "26.4.2", "snowpack": "2.10.1", "typescript": "4.0.2", diff --git a/frontend/packages/core/src/components/StackChart.tsx b/frontend/packages/core/src/components/StackChart.tsx index 4e755d75..58032e3b 100644 --- a/frontend/packages/core/src/components/StackChart.tsx +++ b/frontend/packages/core/src/components/StackChart.tsx @@ -64,7 +64,7 @@ const StackChart = React.forwardRef }; const rawData = useMemo(() => seriesData.data ?? [], [seriesData.data]); - const negativeY = useMemo(() => minY - (maxY - minY) * 0.4, [minY, maxY]); + const negativeY = useMemo(() => (minY === 0 && maxY === 0 ? -0.4 : minY - (maxY - minY) * 0.4), [minY, maxY]); const getPoint = useCallback( (x: number, y: number, z: number, getCoord: GetCoord) => { -- GitLab