From 2e7569303d0aaef4a790a52e355af848030c90bb Mon Sep 17 00:00:00 2001
From: Nicky Chan <nicky@baidu.com>
Date: Tue, 21 Aug 2018 14:54:16 -0700
Subject: [PATCH] fix Favicon not show up (#488)

---
 frontend/src/{images => assets}/favicon.png | Bin
 frontend/template/index.html                |   2 +-
 frontend/tool/webpack.config.js             |   4 +++-
 3 files changed, 4 insertions(+), 2 deletions(-)
 rename frontend/src/{images => assets}/favicon.png (100%)

diff --git a/frontend/src/images/favicon.png b/frontend/src/assets/favicon.png
similarity index 100%
rename from frontend/src/images/favicon.png
rename to frontend/src/assets/favicon.png
diff --git a/frontend/template/index.html b/frontend/template/index.html
index 80938f1a..04a72f9f 100755
--- a/frontend/template/index.html
+++ b/frontend/template/index.html
@@ -5,7 +5,7 @@
         <title>Visual DL</title>
         <meta name="viewport" content="width=device-width, initial-scale=1">
         <meta http-equiv="X-UA-Compatible" content="IE=Edge">
-        <link rel="shortcut icon" type="image/png" href="/static/favicon.png" />
+        <link rel="shortcut icon" type="image/png" href="favicon.png" />
         <link href='https://fonts.googleapis.com/css?family=Roboto:300,400,500,700|Material+Icons' rel="stylesheet">
         <script type="text/javascript" src="https://dagrejs.github.io/project/dagre-d3/latest/dagre-d3.min.js"></script>
     </head>
diff --git a/frontend/tool/webpack.config.js b/frontend/tool/webpack.config.js
index a6379f64..f128fa28 100644
--- a/frontend/tool/webpack.config.js
+++ b/frontend/tool/webpack.config.js
@@ -7,6 +7,7 @@ const argv = require('yargs').argv;
 const isDev = process.env.NODE_ENV === 'dev';
 const entry = require('./entry');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
+const HtmlWebpackPlugin = require('html-webpack-plugin');
 
 function getLoaders(isDev, ext) {
     let arr = ['css-loader'];
@@ -122,7 +123,8 @@ const config = {
         new webpack.LoaderOptionsPlugin({
             test: /\.(styl)$/
         }),
-        new ExtractTextPlugin({filename: '[name].css'})
+        new ExtractTextPlugin({filename: '[name].css'}),
+        new HtmlWebpackPlugin({favicon: 'src/assets/favicon.png'})
     ],
     externals: {
         dagreD3: 'dagre-d3',
-- 
GitLab